Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: always set session-id cookie in example middleware #74

Merged
merged 2 commits into from
May 31, 2024

Conversation

daveleek
Copy link
Contributor

About the changes

Modifies the existing root middleware to always set the unleash-session-id cookie, regardless of path

example/src/middleware.ts Outdated Show resolved Hide resolved
Copy link

@sjaanus sjaanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG with comment

@kwasniew kwasniew self-requested a review May 31, 2024 11:05
@daveleek daveleek merged commit 12d0b06 into main May 31, 2024
5 checks passed
@daveleek daveleek deleted the feat/add-cookie-middleware-to-example-root branch May 31, 2024 11:08
renovate bot referenced this pull request in simonknittel/simonknittel.de Jul 5, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@unleash/nextjs](https://togithub.com/Unleash/unleash-client-nextjs)
| [`1.4.3` ->
`1.4.4`](https://renovatebot.com/diffs/npm/@unleash%2fnextjs/1.4.3/1.4.4)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@unleash%2fnextjs/1.4.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@unleash%2fnextjs/1.4.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@unleash%2fnextjs/1.4.3/1.4.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@unleash%2fnextjs/1.4.3/1.4.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>Unleash/unleash-client-nextjs
(@&#8203;unleash/nextjs)</summary>

###
[`v1.4.4`](https://togithub.com/Unleash/unleash-client-nextjs/releases/tag/v1.4.4)

[Compare
Source](https://togithub.com/Unleash/unleash-client-nextjs/compare/v1.4.3...v1.4.4)

#### What's Changed

- feat: always set session-id cookie in example middleware by
[@&#8203;daveleek](https://togithub.com/daveleek) in
[https://github.com/Unleash/unleash-client-nextjs/pull/74](https://togithub.com/Unleash/unleash-client-nextjs/pull/74)
- Fix: prevent middleware log errors by
[@&#8203;Tymek](https://togithub.com/Tymek) in
[https://github.com/Unleash/unleash-client-nextjs/pull/78](https://togithub.com/Unleash/unleash-client-nextjs/pull/78)
- chore: update dependencies and build - turbo, pnpm, node by
[@&#8203;Tymek](https://togithub.com/Tymek) in
[https://github.com/Unleash/unleash-client-nextjs/pull/79](https://togithub.com/Unleash/unleash-client-nextjs/pull/79)
- fix: yarn build by [@&#8203;Tymek](https://togithub.com/Tymek) in
[https://github.com/Unleash/unleash-client-nextjs/pull/80](https://togithub.com/Unleash/unleash-client-nextjs/pull/80)
- chore: update dependencies by
[@&#8203;Tymek](https://togithub.com/Tymek) in
[https://github.com/Unleash/unleash-client-nextjs/pull/82](https://togithub.com/Unleash/unleash-client-nextjs/pull/82)

#### New Contributors

- [@&#8203;daveleek](https://togithub.com/daveleek) made their first
contribution in
[https://github.com/Unleash/unleash-client-nextjs/pull/74](https://togithub.com/Unleash/unleash-client-nextjs/pull/74)

**Full Changelog**:
Unleash/unleash-client-nextjs@v1.4.3...v1.4.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/simonknittel/simonknittel.de).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6W119-->
simonknittel referenced this pull request in simonknittel/sinister-incorporated Jul 6, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@unleash/nextjs](https://togithub.com/Unleash/unleash-client-nextjs)
| dependencies | patch | [`1.4.3` ->
`1.4.4`](https://renovatebot.com/diffs/npm/@unleash%2fnextjs/1.4.3/1.4.4)
|

---

### Release Notes

<details>
<summary>Unleash/unleash-client-nextjs
(@&#8203;unleash/nextjs)</summary>

###
[`v1.4.4`](https://togithub.com/Unleash/unleash-client-nextjs/releases/tag/v1.4.4)

[Compare
Source](https://togithub.com/Unleash/unleash-client-nextjs/compare/v1.4.3...v1.4.4)

#### What's Changed

- feat: always set session-id cookie in example middleware by
[@&#8203;daveleek](https://togithub.com/daveleek) in
[https://github.com/Unleash/unleash-client-nextjs/pull/74](https://togithub.com/Unleash/unleash-client-nextjs/pull/74)
- Fix: prevent middleware log errors by
[@&#8203;Tymek](https://togithub.com/Tymek) in
[https://github.com/Unleash/unleash-client-nextjs/pull/78](https://togithub.com/Unleash/unleash-client-nextjs/pull/78)
- chore: update dependencies and build - turbo, pnpm, node by
[@&#8203;Tymek](https://togithub.com/Tymek) in
[https://github.com/Unleash/unleash-client-nextjs/pull/79](https://togithub.com/Unleash/unleash-client-nextjs/pull/79)
- fix: yarn build by [@&#8203;Tymek](https://togithub.com/Tymek) in
[https://github.com/Unleash/unleash-client-nextjs/pull/80](https://togithub.com/Unleash/unleash-client-nextjs/pull/80)
- chore: update dependencies by
[@&#8203;Tymek](https://togithub.com/Tymek) in
[https://github.com/Unleash/unleash-client-nextjs/pull/82](https://togithub.com/Unleash/unleash-client-nextjs/pull/82)

#### New Contributors

- [@&#8203;daveleek](https://togithub.com/daveleek) made their first
contribution in
[https://github.com/Unleash/unleash-client-nextjs/pull/74](https://togithub.com/Unleash/unleash-client-nextjs/pull/74)

**Full Changelog**:
Unleash/unleash-client-nextjs@v1.4.3...v1.4.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjQuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQyNC4yIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6W119-->

Co-authored-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants