Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

79 create endpoints for activity #110

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

DeepakR-Sastry
Copy link

No description provided.

Copy link
Collaborator

@Sooraj-beep Sooraj-beep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also include testcases for all endpoints ( 1 passing and 1 failing for each operation would be ideal with extra boundary condition testcases if you can think of any)



//////// Create a database model //////
const ActivitySchema = new Schema({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesnt the Activity also contain a post object? which is a list of post ids?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already intimated that the post objects aren't added because we don't have a model for it yet; in the standup last week I told that I could go back and add post objects once we create a model for it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could still include in the schema but send a null value for now

Copy link
Collaborator

@Sooraj-beep Sooraj-beep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also include test cases in this commit? (1 passing and 1 failing for each operation would be ideal with extra boundary condition test cases if you can think of any)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants