-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
79 create endpoints for activity #110
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also include testcases for all endpoints ( 1 passing and 1 failing for each operation would be ideal with extra boundary condition testcases if you can think of any)
|
||
|
||
//////// Create a database model ////// | ||
const ActivitySchema = new Schema({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesnt the Activity also contain a post object? which is a list of post ids?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have already intimated that the post objects aren't added because we don't have a model for it yet; in the standup last week I told that I could go back and add post objects once we create a model for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could still include in the schema but send a null value for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also include test cases in this commit? (1 passing and 1 failing for each operation would be ideal with extra boundary condition test cases if you can think of any)
No description provided.