Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction CIRCLE avec angle négatif (correct circle with negative angle) #294

Open
wants to merge 4 commits into
base: upsilon-dev
Choose a base branch
from

Conversation

fmOOmf
Copy link

@fmOOmf fmOOmf commented Oct 26, 2022

Permet d'utiliser cercle(rayon,angle) avec un angle negatif.
Quand angle est positif, la tortue dessine le cercle en marche avant.
Quand angle est negatif, la tortue dessine le cercle en marche arrière.


Allow cercle(radius,angle) with negative angle value.
When angle is positive, the turtle draws the circle forwards.
When angle is negative, the turtle draws the circle backwards.

@github-actions
Copy link

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 821588 bytes 478157 bytes 226384 bytes 1816 bytes 228200 bytes 1301561 bytes
Head 821644 bytes 478157 bytes 226384 bytes 1816 bytes 228200 bytes 1301617 bytes
+56 bytes +0 bytes +0 bytes +0 bytes +0 bytes +56 bytes
+0.0 % +0.0 % +0.0 % +0.0 % +0.0 % +0.0 %

@github-actions
Copy link

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 821588 bytes 478157 bytes 226384 bytes 1816 bytes 228200 bytes 1301561 bytes
Head 821676 bytes 478157 bytes 226384 bytes 1816 bytes 228200 bytes 1301649 bytes
+88 bytes +0 bytes +0 bytes +0 bytes +0 bytes +88 bytes
+0.0 % +0.0 % +0.0 % +0.0 % +0.0 % +0.0 %

Copy link
Member

@Yaya-Cout Yaya-Cout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little changes to do, but most of the code seems right.

@fmOOmf fmOOmf requested a review from Yaya-Cout October 26, 2022 20:14
@github-actions
Copy link

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 821588 bytes 478157 bytes 226384 bytes 1816 bytes 228200 bytes 1301561 bytes
Head 821676 bytes 478157 bytes 226384 bytes 1816 bytes 228200 bytes 1301649 bytes
+88 bytes +0 bytes +0 bytes +0 bytes +0 bytes +88 bytes
+0.0 % +0.0 % +0.0 % +0.0 % +0.0 % +0.0 %

Copy link
Member

@Yaya-Cout Yaya-Cout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change and it will be good !

python/port/mod/turtle/turtle.cpp Outdated Show resolved Hide resolved
Co-authored-by: Yaya-Cout <[email protected]>
@github-actions
Copy link

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 821588 bytes 478157 bytes 226384 bytes 1816 bytes 228200 bytes 1301561 bytes
Head 821676 bytes 478157 bytes 226384 bytes 1816 bytes 228200 bytes 1301649 bytes
+88 bytes +0 bytes +0 bytes +0 bytes +0 bytes +88 bytes
+0.0 % +0.0 % +0.0 % +0.0 % +0.0 % +0.0 %

@fmOOmf
Copy link
Author

fmOOmf commented Oct 27, 2022

Thanks for this review, for the hints and suggestions.
One more step towards perfection ☺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants