Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLUGINS-1775] Added mqsiprofile script field to broker steps : create, delete, star… #36

Open
wants to merge 2 commits into
base: air
Choose a base branch
from

Conversation

Jyoti-Prakash01
Copy link

…t, stop.

@Jyoti-Prakash01 Jyoti-Prakash01 requested a review from jrbarto July 2, 2019 12:23
Copy link
Member

@jrbarto jrbarto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey JP. I don't get what you're doing here. All you did was create a bunch of properties in the plugin.xml, and they're never used in the scripts.

Also, jarPath isn't a necessary field. If you need help with this please ask for it.

@Jyoti-Prakash01
Copy link
Author

The properties those I have created are used by mqsi_profile_wrapper.groovy. Which is being passed for broker steps in plugins.xml. Let me know if I am wrong.

@Jyoti-Prakash01
Copy link
Author

Also, along with jarPath and other properties that I have added are being used in mqsi_profile_wrapper.groovy.

@jrbarto
Copy link
Member

jrbarto commented Jul 2, 2019

Oh okay, I see you're using the wrapper now instead of directly using the script. I think that's a good call. However, the jarPath shouldn't be a property for mqsi scripts. That property is only necessary when using the Java IBM Integration API. Otherwise it's useless and just makes the step more complicated.

Note that if you straight up remove the property right now it would break the plugin. In the wrapper script there is a split statement that splits the contents of the jarPath. You can remove the jarPath property from your new steps if you modify the wrapper script to first check if jarPath exists before splitting its contents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants