Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: various fix for UserDictWord #1002

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Feb 11, 2025

内容

  1. C APIとRust APIのみpriorityのデフォルトが5ではなく0になっていたため、5に合わせることでPython, Java, VOICEVOX ENGINEに合わせる。
  2. VOICEVOX ENGINEにならった場合、surface, pronounciationと同様accent_typeもrequiredであるはずなので、そうしてしまう。
  3. impl Default for UserDictWordを削除

関連 Issue

その他

@qryxip qryxip requested a review from Hiroshiba February 11, 2025 13:58
@qryxip qryxip force-pushed the pr/fix-various-fix-for-userdictword branch from dc67672 to a7d0962 Compare February 11, 2025 14:01
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

これは0.17以降に導入すると破壊的変更になってしまうので、0.16に入れたい・・・!

@qryxip qryxip merged commit 71504d9 into VOICEVOX:main Feb 12, 2025
31 checks passed
@qryxip qryxip deleted the pr/fix-various-fix-for-userdictword branch February 12, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants