feat!: VoiceModelFile::close後もidとmetasへのアクセスを保証
#937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
changed the title
VoiceModelFile::close後もidとmetasへのアクセスを保証VoiceModelFile::close後もidとmetasへのアクセスを保証
qryxip
changed the title
VoiceModelFile::close後もidとmetasへのアクセスを保証VoiceModelFile::close後もidとmetasへのアクセスを保証
qryxip
force-pushed
the
feat-ensure-voice-model-file-id-and-metas-accessible
branch
2 times, most recently
from
8429882 to
99530cc
Compare
qryxip
force-pushed
the
feat-ensure-voice-model-file-id-and-metas-accessible
branch
from
99530cc to
c8afcda
Compare
qryxip
changed the title
VoiceModelFile::close後もidとmetasへのアクセスを保証VoiceModelFile::close後もidとmetasへのアクセスを保証
qryxip
commented
Jan 24, 2025
There was a problem hiding this comment.
ちょっと若干迷っていて、voicevox_voice_model_file_delete一本に絞ってもよいかもしれません。idとか知りたきゃ先に取っておけみたいな感じで。
There was a problem hiding this comment.
考えたのですが、voicevox_voice_model_file_delete一本にしてしまいました。これによりC APIの変更は「voicevox_voice_model_file_closeをdeleteに改名」ということのみになります。理由としてはC API経由でバインディングを作る人とかに混乱をもたらすだろうと思ったからです。あと実装面でも(既にご覧になったと思いますが)小さくない複雑性をもたらすので、少なくとも今は要らないかなと思った次第です。
Hiroshiba
approved these changes
Jan 24, 2025
Hiroshiba
reviewed
Jan 24, 2025
Hiroshiba
approved these changes
Jan 25, 2025
|
ちょっと理解しきれてないかもなのですが、それをやっているのがPythonとJavaで、Rustではムーブセマンティクスの概念に沿う形がいいかなと思ってます。このPRのdocs/guide/dev/api-design.mdに書いたみたいに。 |
qryxip
deleted the
feat-ensure-voice-model-file-id-and-metas-accessible
branch
|
あ、ほんとですね！ openするとインスタンスが帰ってくるようになってたので問題なかった！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
VoiceModelFile::closeの返り値を()から(VoiceModelId, Vec<SpeakerMeta>)にvoicevox_voice_model_file_closeとvoicevox_voice_model_file_deleteの二つを提供するようにvoicevox_voice_model_file_closeをvoicevox_voice_model_file_deleteに改名__(a)exit__後もidとmetasにアクセス可能であることをドキュメント上で約束関連 Issue
その他