Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: is_productionを廃止 #979

Merged
merged 3 commits into from
Feb 7, 2025
Merged

build: is_productionを廃止 #979

merged 3 commits into from
Feb 7, 2025

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Feb 7, 2025

内容

build and deploy workflowのTODOを解消する形。

関連 Issue

Refs: #825 (comment)

その他

@qryxip qryxip requested a review from Hiroshiba February 7, 2025 04:38
@qryxip qryxip mentioned this pull request Feb 7, 2025
Merged
Hiroshiba
Hiroshiba approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

あ、１点だけ変更お願いします！

.github/workflows/build_and_deploy.yml Outdated Show resolved Hide resolved
@qryxip qryxip merged commit 55f24dd into VOICEVOX:main Feb 7, 2025
29 checks passed
@qryxip qryxip deleted the pr/build-remove-is-production branch February 7, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qryxip @Hiroshiba