-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging EA into Mainline #979
Conversation
* Disable the RealTimeStylus for WPF Applications * Update MainWindow.xaml.cs * test ?
* restore Legion Go FanControl ability (requires BIOS v29) * Implement Sapientia function getUSBVerify() * Implement WMI class (wip) * implement new functions - GetFanFullSpeedAsync - SetFanFullSpeedAsync - SetFanTable - SetSmartFanMode * implement SetCPUPowerLimit()
* Start implementing IGCL (wip) * More work - Implemented GPUManager - Implemented GPU-specific classes (AMDGPU, IntelGPU) - Implemented IGCLBackend (wip) - SystemManager renamed to MultimediaManager - PowerManager renamed to SystemManager * more work on IGCL * prevent crash on null MainThread * prevent useless SetResolution() calls * more work on IGCL * add missing sharpness check * implement ctl_device_adapter_properties_t (wip) * what if the issue was deviceIdx all along... * Update IGCL_Wrapper.dll * fix remaining implementations * implement IntegerScalingType (Intel only) * make sure to use defaultGPU (idx: 0) We need to find a proper way to guess which one is used for 3D rendering I guess or linked to main screen.. * fix ctl_device_adapter_properties_t Marshalling * implemented some form of logic to pick the first available external GPU (if any) * improve GPUManager - add support for Manufacturer: "Advanced Micro Devices, Inc." - improve GPUManager and GPU Start() and Stop() logics - prevent Task Execution within Tasks on AMDGPU * fix a crash when UpdateTimer is null
* Implement new UI classes - UISounds to manage UI sounds on interaction. - UIGamepad to manage gamepad interactions. - Audio files from https://kenney.nl/assets/ui-audio. - Add support for TextBox and RepeatButton selection via gamepad. * Update HandheldCompanion/UI/UISounds.cs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix PlayOggFile refs * removed unused audio files * Add UI Sounds toggle on SettingsPage (default Off) --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* Migrate everything ADLX related to ADLX_Wrapper() * update IGCL logic - Implemented Terminate() and Initialize() as well as GetTelemetryData() * debug functions on both IGCL and ADLX backends * Update ADLX_Wrapper and fix Initialize() calls on GPU classes * add Telemetry Timer as part of GPU class * Implement GPU GetLoad() and GetPower()
* SapientiaUsb update * Legion Go - additional settings
#951) * fixed issue with layoutmanager crashing when dismissing the quick settings * Update HandheldCompanion/Managers/LayoutManager.cs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@0SkillAllLuck, we shouldn't loop through all video controllers but instead only look for "main" one
* Update ControllerPage and IController UI logic a bit Should simplify the virtual/physical distinction * more work on UI * minor tweaks * misc text tweaks * more work on UI * improve wording
When navigating, don't focus TextBox if IsReadOnly
This should prevent AutoTDP and TDP control to flood the log.
- GPUManager should be started before Profile and PowerProfile managers to avoid an IGCL/ADLX calls from being made before they're initialized. - Implemented an IsInitialized check before executing any ADLX/IGCL calls. - Implemented a try{] catch{} on GPU Execute(). - Halt Telemetry timer before closing IGCL/ADLX.
* Improvement, translations update. * Localization support for Device page Legion Go settings.
when device is null
<data name="QuickSettingsPage_DisplayFrequency" xml:space="preserve"> | ||
<value>Refresh rate</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for QuickSettingsPage_DisplayFrequency
.
<data name="QuickSettingsPage_DisplayFrequencyDesc" xml:space="preserve"> | ||
<value>Adjust main refresh rate</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for QuickSettingsPage_DisplayFrequencyDesc
.
<data name="ProfilesPage_FanSettings" xml:space="preserve"> | ||
<value>Fan settings</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for ProfilesPage_FanSettings
.
<data name="ProfilesPage_FanSettingsDesc" xml:space="preserve"> | ||
<value>Change the fan settings</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for ProfilesPage_FanSettingsDesc
.
<data name="ProfilesPage_CreatePowerProfile" xml:space="preserve"> | ||
<value>Create a new power preset</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for ProfilesPage_CreatePowerProfile
.
<data name="ProfilesPage_CreatePowerProfileButton" xml:space="preserve"> | ||
<value>Create power preset</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for ProfilesPage_CreatePowerProfileButton
.
<data name="ProfilesPage_DeletePowerProfileButton" xml:space="preserve"> | ||
<value>Delete power preset</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for ProfilesPage_DeletePowerProfileButton
.
<data name="MainWindow_Toggle" xml:space="preserve"> | ||
<value>Toggle</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for MainWindow_Toggle
.
<data name="XInputController_Warning_USB" xml:space="preserve"> | ||
<value>Please wait a moment while we power cycle your controller.</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for XInputController_Warning_USB
.
<data name="LayoutPage_SetAsDefault" xml:space="preserve"> | ||
<value>Make this the default layout</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for LayoutPage_SetAsDefault
.
<data name="InputsHotkey_shortcutChangeHIDMode" xml:space="preserve"> | ||
<value>Toggle emulated controller type</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for InputsHotkey_shortcutChangeHIDMode
.
<data name="InputsHotkey_shortcutChangeHIDModeDesc" xml:space="preserve"> | ||
<value>Toggle between Xbox 360 and Dualshock 4 emulated controllers</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for InputsHotkey_shortcutChangeHIDModeDesc
.
<data name="QuickHomePage_Title" xml:space="preserve"> | ||
<value>Home</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for QuickHomePage_Title
.
<data name="QuickDevicePage_Title" xml:space="preserve"> | ||
<value>Device</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for QuickDevicePage_Title
.
<data name="QuickDevicePage_Desc" xml:space="preserve"> | ||
<value>Settings, display profile</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for QuickDevicePage_Desc
.
<data name="PowerProfileROGAllyTurboName" xml:space="preserve"> | ||
<value>ROG Ally - Turbo</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for PowerProfileROGAllyTurboName
.
<data name="DevicePage_DynamicLighting_Wheel" xml:space="preserve"> | ||
<value>Wheel</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for DevicePage_DynamicLighting_Wheel
.
<data name="DevicePage_DynamicLighting_MatchAccentColor" xml:space="preserve"> | ||
<value>Match my Windows accent color</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for DevicePage_DynamicLighting_MatchAccentColor
.
<data name="DevicePage_DynamicLighting_SecondColorSelection" xml:space="preserve"> | ||
<value>Second color</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for DevicePage_DynamicLighting_SecondColorSelection
.
<data name="DevicePage_DynamicLighting_EffectSpeed" xml:space="preserve"> | ||
<value>Effect speed</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for DevicePage_DynamicLighting_EffectSpeed
.
<data name="DevicePage_DynamicLighting_EffectDirection" xml:space="preserve"> | ||
<value>Direction</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for DevicePage_DynamicLighting_EffectDirection
.
<data name="MainWindow_navPerformance" xml:space="preserve"> | ||
<value>Performance</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for MainWindow_navPerformance
.
<data name="PerformancePage_Device" xml:space="preserve"> | ||
<value>Performance</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for PerformancePage_Device
.
<data name="ProfilesPage_CPUMhz" xml:space="preserve"> | ||
<value>CPU Clock max frequency</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for ProfilesPage_CPUMhz
.
<data name="QuickPerformancePage_CPUControl" xml:space="preserve"> | ||
<value>Manual CPU Clock Control</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for QuickPerformancePage_CPUControl
.
<data name="DevicePage_DynamicLighting_Rainbow" xml:space="preserve"> | ||
<value>Rainbow</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for DevicePage_DynamicLighting_Rainbow
.
<data name="QuickPerformancePage_CPUControlDesc" xml:space="preserve"> | ||
<value>Sets the CPU to a fixed clock</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for QuickPerformancePage_CPUControlDesc
.
<data name="PowerProfileDefaultDescription" xml:space="preserve"> | ||
<value>Default power and fan speed for optimal performance, temperature, noise, and battery life.</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for PowerProfileDefaultDescription
.
<data name="PowerProfileDefaultName" xml:space="preserve"> | ||
<value>Default</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for PowerProfileDefaultName
.
<data name="PowerProfileManualDescription" xml:space="preserve"> | ||
<value>User-defined power and fan speed.</value> | ||
</data> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation for PowerProfileManualDescription
.
Summary by CodeRabbit
New Features
Enhancements
Bug Fixes
Refactor