Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Analytics 90d and sort search by download counts #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bwiggs
Copy link

@bwiggs bwiggs commented Mar 2, 2025

First, this is an excellent homebrew TUI tool! Thanks you!

I was looking for a way to browse Homebrew packages by "popularity". This PR adds a new column for Download counts, and also sorts search results by download count.

CleanShot 2025-03-02 at 11 27 38

@Valkyrie00 Valkyrie00 added the enhancement New feature or request label Mar 2, 2025
@Valkyrie00 Valkyrie00 self-requested a review March 2, 2025 22:32
for _, info := range *sourceList {
if strings.Contains(strings.ToLower(info.Name), strings.ToLower(searchText)) ||
strings.Contains(strings.ToLower(info.Description), strings.ToLower(searchText)) {
if strings.Contains(strings.ToLower(info.Name), searchTextLower) ||
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 🚀

@Valkyrie00
Copy link
Owner

Hi @bwiggs 😃 Thank you very much, I'm really happy that you like my project. But especially thanks to you for this new implementation! 🙏

I have verified your code and built the application locally and everything seems to work correctly. I will merge this implementation of yours shortly and release it officially with a new version soon after.

Your contributions are and always will be welcome!

Copy link
Owner

@Valkyrie00 Valkyrie00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants