wlserver: Create a keyboard group to keep all externally connected keyboards in sync #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yboards in sync This ensures that all externally connected keyboards share a common layout and state. If a lock modifier (such as Caps Lock or Num Lock) is enabled or disabled on one keyboard, the state will be propagated to all of them. If a keyboard is disconnected and then reconnected, the layout and state are preserved. This behaviour is consistent with KWin, which is used in desktop mode. Fixes: ValveSoftware/steam-for-linux#11529
|
Doing further testing, I noticed one issue with this PR: when I disconnect/unplug a keyboard when Caps Lock was enabled, when I connect it again the state is preserved, so key presses result in capital letters being input, but the state itself isn't updated on the keyboard, so for keyboards with a LED for Caps Lock it isn't being lit, and the next press on Caps Lock doesn't disable the state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that all externally connected keyboards share a common layout and state. If a lock modifier (such as Caps Lock or Num Lock) is enabled or disabled on one keyboard, the state will be propagated to all of them.
If a keyboard is disconnected and then reconnected, the layout and state are preserved.
This behavior is consistent with KWin, which is used in desktop mode.
Fixes: ValveSoftware/steam-for-linux#11529