MachO/ObjC: Avoid generating names containing non-printable chars #6236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid generating ObjC symbol names containing non-printable characters for both 8 and 16 bit character encodings.
|
|
|
Thank you so much for this PR, I'm currently working through several PRs related to sharedcache processing and will be taking a look at this one within the next couple of weeks as we finish working through those. |
|
FWIW, the issue this PR addresses is exacerbated by latest dev builds displaying symbol names with newlines as multi-line symbol names in the symbol list, leading to a lot of wasted vertical space. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid generating ObjC symbol names containing ASCII control characters for both 8 and 16 bit character encodings.
Behaviour is like before for each, except that ASCII control characters (0..0x1f) are replaced by ?, except for carriage return, line feed, and tabulator characters, which are replaced by \r, \n and \t respectively.
For an example CF string of
"Hello world!\r\n", with this change, the symbol would be namedcfstr_Hello_world!\r\n, instead of w/o this changecfstr_Hello_world!with embedded CR/LF that display as slightly weird spaces.Tested on latest stable by rebasing this change on top of v4.2.6455-stable.