Fix rust EnumerationBuilder method return types #6365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VisualEhrmanntraut
had a problem deploying
to
testing
GitHub Actions
Error
|
Thanks for noticing that, we only ever used them unchained so never ran into that. I'll add some more unit tests today for this and other builders |
|
Hey @emesare, I'm in the BN slack, I've got an inquiry about the Rust API other than this issue. Can you please check the rust-api channel? I would appreciate it. |
|
As in, another problem with the API, not a question |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
methods
append,insert,replace, andremovewere returning&Selfinstead of&mut Self, but accepting&mut Self, so you could add/remove a member only once.