Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/chromatic #98

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Ci/chromatic #98

merged 4 commits into from
Nov 6, 2024

Conversation

Schlomoh
Copy link
Collaborator

@Schlomoh Schlomoh commented Nov 6, 2024

This pull request introduces several updates to the GitHub Actions workflows and a minor change to a Storybook story in the vectreal-viewer package. The key changes include improvements to workflow concurrency management and modifications to the Chromatic publishing process.

Workflow Improvements:

  • .github/workflows/chromatic-vctrl-viewer.yaml:

    • Added concurrency management to ensure only one workflow runs at a time for a given branch.
    • Updated permissions to restrict actions to write and contents to read.
    • Improved job names and added caching for npm dependencies to speed up the workflow.
    • Enhanced the Chromatic step with additional options for better control over the publishing process.
  • .github/workflows/deploy-official-website.yaml:

    • Introduced concurrency management to prevent multiple deployments from running simultaneously on the same branch.

Code Changes:

  • packages/viewer/src/vectreal-viewer.stories.tsx:
    • Updated the controlsOptions in the Default story to disable auto-rotation.

@Schlomoh Schlomoh temporarily deployed to chromatic-publishing November 6, 2024 23:36 — with GitHub Actions Inactive
@Schlomoh Schlomoh merged commit 50875b6 into main Nov 6, 2024
7 checks passed
@Schlomoh Schlomoh deleted the ci/chromatic branch November 6, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packages/viewer - Add integration tests for viewer and the vctrl/hooks integration
1 participant