New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deduplication by defining order in event_params #259

Merged

adamribaudo-velir merged 1 commit into Velir:main from FlorianASchroeder:258-fix-event-deduplication

Jul 31, 2023

Contributor

FlorianASchroeder commented Jul 31, 2023

Description & motivation

resolves #258

Sort event_params by key for improved de-duplication.

Checklist

I have verified that these changes work locally
I have updated the README.md (if applicable)
I have added tests & descriptions to my models (and macros if applicable)
I have run dbt test and python -m pytest . to validate existing tests


          fix deduplication by defining order in event_params

1435e82

Collaborator

adamribaudo-velir commented Jul 31, 2023

Good catch, thanks.

adamribaudo-velir approved these changes

View reviewed changes

adamribaudo-velir merged commit 4ed8af2 into Velir:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet