feat: Add start as minimized toggle to settings #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheKodeToad
reviewed
Nov 18, 2023
Co-authored-by: TheKodeToad <[email protected]>
Vendicated
reviewed
Nov 19, 2023
Co-authored-by: V <[email protected]>
|
Definitely interested in this one, thank you everyone! |
|
this doesn't work, the splash doesn't show but the main app does not start minimised |
|
ah, it seems like this only doesnt work if the app was maximised when it was quit. when windowing the app before quitting, it works as intended |
Vendicated
reviewed
Dec 2, 2023
lewisakura
approved these changes
Dec 9, 2023
|
thank you! |
Vendicated
added a commit
that referenced
this pull request
Dec 9, 2023
This reverts commit 40b952d.
|
i don't think this feature makes much sense in its current state. who would want to explicitly open vesktop and have it open minimised? when you open it with an explicit action, you want it to be usable immediately the only case where users realistically would want vesktop to start minimised is if the action was implicit, so via the start with system option. i think this option should be reworked to be exactly that |
Vendicated
added a commit
that referenced
this pull request
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible for the user to start Vesktop in minimized mode. Meaning no splash screen nor the main window appearing on launch. Resolves #242