reorg SPV #340
Draft
reorg SPV #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warchant
approved these changes
Nov 19, 2021
memekas
changed the title
Warchant
reviewed
Nov 26, 2021
nodecore-spv/src/main/java/org/veriblock/spv/net/PeerEventListener.kt
Outdated
Show resolved
Hide resolved
Warchant
reviewed
Dec 13, 2021
nodecore-spv/build.gradle.kts
Outdated
| implementation("org.slf4j:slf4j-api:$slf4jVersion") | ||
| implementation("io.github.microutils:kotlin-logging:2.0.11") | ||
| implementation("org.apache.logging.log4j:log4j-api:2.14.1") | ||
| implementation("org.apache.logging.log4j:log4j-core:2.14.1") |
Warchant
reviewed
Dec 15, 2021
| if (blockMessage.previousHash.size() == VBK_HASH_LENGTH_FULL) | ||
| blockMessage.previousHash.substring(VBK_HASH_LENGTH).asVbkPreviousBlockHash() | ||
| else | ||
| blockMessage.previousHash.asVbkPreviousBlockHash(), |
There was a problem hiding this comment.
I suggest to add this size check into asVbkPreviousBlockHash.
So that if previousHash is 12 or 24, asVbkPreviousBlockHash will do this size check + substring and then create proper hash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.