Fix display entities causing crashes on 1.19.3 and below #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It'd be better if they were explicitly removed/handled below, something running into that suggest one of those handlers/index removals is missing |
|
Ah, I see what the problem is now. I totally missed that the tracked entity is null here and the problems that it caused internally in ViaVersion just made things a bit more confusing. It does not know what to remove and that just cascades more and more as it goes down the translation pipeline. Closing, finding the root cause is better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like this was removed in 8715c24 and I'm not seeing any reason to do so? Not removing it causes problems downstream.