Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1.20.2 configuration ping packet handling #658

Closed
wants to merge 1 commit into from

Conversation

isjerryxiao
Copy link

1.20.1- clients (even vanilla) currently times out when join 1.20.2+ fabric servers with fabric api installed.

The client really does not have a way of sending pong in this stage. Even if it does, the current implementation is still broken as play state ping packet has a LONG payload instead of a INT one.

The client really does not have a way of sending pong in this stage. Even if it does, the current implementation is still broken as play state ping packet has a LONG payload instead of a INT one.
@Kichura
Copy link
Member

Kichura commented Dec 22, 2023

Has this PR also been tested with viarewind? (1.8.9 clients to be specific)

@isjerryxiao
Copy link
Author

Has this PR also been tested with viarewind? (1.8.9 clients to be specific)

Not yet.

@Kichura
Copy link
Member

Kichura commented Dec 24, 2023

Since i have time to do it, will give a try now.

@Kichura
Copy link
Member

Kichura commented Dec 24, 2023

Did the testing and 1.19.0 and older clients still seem to struggle trying to get past the "Joining World" text, 1.19.1 and above are perfectly fine. Re-Ran it and now none of the older clients can connect.

@FlorianMichael
Copy link
Member

Joining a 1.20.4 Fabric server with latest ViaFabric and ViaBackwards installed using a 1.20.1 Vanilla client works without any issues (Fabric API is also installed on the server.)

@Kichura
Copy link
Member

Kichura commented Feb 5, 2024

1.19.0 and older still has yet to be resolved although i mostly assume it's chat reporting related or something.

@FlorianMichael
Copy link
Member

If the server has enforce secure profiles enabled, we can't fix it.

@Kichura
Copy link
Member

Kichura commented Feb 5, 2024

If the server has enforce secure profiles enabled, we can't fix it.

the thing is, it still times out there even with it off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants