fix lint issues and run static analysis for all modules

app/build.gradle

@@ -2,9 +2,6 @@ apply plugin: 'com.android.application'
 apply from: configFile('android-common-config.gradle')
 apply plugin: 'com.novoda.android-command'
 apply plugin: 'com.novoda.build-properties'
-apply plugin: 'com.novoda.static-analysis'
-apply plugin: 'io.gitlab.arturbosch.detekt'
-apply plugin: 'org.jlleitschuh.gradle.ktlint'
 
 buildProperties {
   signing.using(configFile('release.signing')) | configFile('debug.signing')
@@ -60,39 +57,6 @@ android {
   }
 }
 
-staticAnalysis {
-  penalty {
-    maxWarnings = 10
-    maxErrors = 0
-  }
-
-  detekt {
-    config = files(configFile('detekt.yml'))
-  }
-
-  ktlint {
-    reporters {
-      reporter "checkstyle"
-    }
-
-    includeVariants { it.name == 'flossDebug' }
-  }
-
-  lintOptions {
-    textReport true
-    textOutput 'stdout'
-
-    checkAllWarnings true
-    checkReleaseBuilds false
-
-    if (System.env.TRAVIS_BRANCH != 'master') ignore 'MissingTranslation'
-
-    lintConfig configFile('lint.xml')
-
-    includeVariants { it.name == 'flossDebug' }
-  }
-}
-
 if (isPlay) {
   apply from: configFile('fabric.gradle')
   apply from: configFile('play-publish.gradle')

app/src/main/res/values/colors.xml

@@ -1,7 +1,4 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
-
   <color name="error_color">#FFDD2C00</color>
-
-  <color name="feature_switch_background">#EEE</color>
 </resources>

base/src/main/kotlin/com/tasomaniac/openwith/extensions/Resources.kt

@@ -3,7 +3,6 @@ package com.tasomaniac.openwith.extensions
 import android.content.res.Resources
 import android.util.TypedValue
 
-
 fun Resources.dpToPx(dp: Int): Int {
     return TypedValue
         .applyDimension(TypedValue.COMPLEX_UNIT_DIP, dp.toFloat(), displayMetrics).toInt()

base/src/main/res/values/colors.xml

@@ -3,4 +3,7 @@
   <color name="theme_primary">#3F51B5</color>
   <color name="theme_primary_dark">#303F9F</color>
   <color name="theme_accent">#009688</color>
+
+  <color name="window_background">@color/material_grey_50</color>
+  <color name="feature_switch_background">#EEE</color>
 </resources>

build.gradle

@@ -58,6 +58,10 @@ allprojects {
         google()
         mavenCentral()
     }
+
+    if (project.name != 'test-support') {
+        apply from: configFile('static-analysis.gradle')
+    }
 }
 
 apply plugin: 'com.github.ben-manes.versions'

gradle/lint.xml

@@ -19,8 +19,6 @@
   </issue>
   <issue id="TypographyEllipsis" severity="error" />
   <issue id="SimpleDateFormat" severity="error" />
-  <issue id="ThrowableNotAtBeginning" severity="error" />
-  <issue id="BinaryOperationInTimber" severity="error" />
   <issue id="WifiManagerPotentialLeak" severity="error" />
 
   <issue id="ObsoleteLintCustomCheck"

gradle/static-analysis.gradle

@@ -0,0 +1,40 @@
+apply plugin: 'io.gitlab.arturbosch.detekt'
+apply plugin: 'org.jlleitschuh.gradle.ktlint'
+apply plugin: 'com.novoda.static-analysis'
+
+
+staticAnalysis {
+    penalty {
+        maxWarnings = 10
+        maxErrors = 0
+    }
+
+    detekt {
+        config = files(configFile('detekt.yml'))
+    }
+
+    ktlint {
+        disabledRules = ['import-ordering']
+        reporters {
+            reporter 'checkstyle'
+        }
+
+        includeVariants { it.name in ['flossDebug', 'debug'] }
+    }
+
+    lintOptions {
+        textReport true
+        textOutput 'stdout'
+
+        checkAllWarnings true
+        checkTestSources false
+        checkReleaseBuilds false
+        checkDependencies false
+
+        if (System.env.TRAVIS_BRANCH != 'master') ignore 'MissingTranslation'
+
+        lintConfig configFile('lint.xml')
+
+        includeVariants { it.name in ['flossDebug', 'debug'] }
+    }
+}