k8s-stack: allow manage default dashboards independently (#1852)

VictoriaMetrics · Dec 4, 2024 · 48ebc7a · 48ebc7a
1 parent 95f0f9c
commit 48ebc7a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/charts/victoria-metrics-k8s-stack/CHANGELOG.md b/charts/victoria-metrics-k8s-stack/CHANGELOG.md
@@ -1,6 +1,6 @@
 ## Next release
 
-- TODO
+- Set higher priority for `defaultDashboards.dashboards.<name>.enabled` flag comparing to default dashboard conditions to allow install or ignore dashboards regardless of whether component it's for is installed or monitored. See [this issue](https://github.com/VictoriaMetrics/helm-charts/issues/1851).
 
 ## 0.30.2
 

diff --git a/charts/victoria-metrics-k8s-stack/templates/grafana/dashboard.yaml b/charts/victoria-metrics-k8s-stack/templates/grafana/dashboard.yaml
@@ -24,7 +24,10 @@ Get dashboard data from file
 {{- /*
 Save condition for a dashboard from file
 */}}
-{{- $dashboardCondition := or $dashboardData.condition (dig $dashboardName "enabled" false $.Values.defaultDashboards.dashboards) -}}
+{{- $dashboardCondition := $dashboardData.condition }}
+{{- if hasKey (index ((($.Values).defaultDashboards).dashboards) $dashboardName) "enabled" }}
+  {{- $dashboardCondition = index $.Values.defaultDashboards.dashboards $dashboardName "enabled" }}
+{{- end }}
 
 {{- /*
 Delete condition from dashboard