Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support HPA for statefulset #1642

Merged
merged 1 commit into from
Oct 29, 2024
Merged

support HPA for statefulset #1642

merged 1 commit into from
Oct 29, 2024

Conversation

AndrewChubatiuk
Copy link
Collaborator

fixes #1641

@github-actions github-actions bot added agent vmagent helm chart related issue cluster vmcluster helm chart related issue labels Oct 28, 2024
f41gh7
f41gh7 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f41gh7
Copy link
Collaborator

f41gh7 commented Oct 28, 2024

It'd be great to mention some where at docs, that HPA for vmagent cannot be used to scale scrapping workload. In this case VPA should be used.

HPA is really useful for the cases:

  1. streaming aggregation.
  2. data ingestion via push protocols
  3. data ingestion from kafka/pubsub at ent version

@AndrewChubatiuk AndrewChubatiuk merged commit 3f51d53 into master Oct 29, 2024
11 checks passed
@AndrewChubatiuk AndrewChubatiuk deleted the configurable-hpa-target branch October 29, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f41gh7 f41gh7 f41gh7 approved these changes

@zekker6 zekker6 Awaiting requested review from zekker6 zekker6 is a code owner

@Haleygo Haleygo Awaiting requested review from Haleygo Haleygo is a code owner

Assignees
No one assigned
Labels
agent vmagent helm chart related issue cluster vmcluster helm chart related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: support HPA for STS
2 participants
@AndrewChubatiuk @f41gh7