Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

victoria-metrics-cluster: fix vminsert template for extra volumes #777

Merged
merged 1 commit into from
Dec 8, 2023
Merged

victoria-metrics-cluster: fix vminsert template for extra volumes #777

merged 1 commit into from
Dec 8, 2023

Conversation

zekker6
Copy link
Contributor

@zekker6 zekker6 commented Dec 8, 2023

Previously, using extraVolumes would trigger an error:

Error: UPGRADE FAILED: template: templates/vminsert-deployment.yaml:168:12: executing "templates/vminsert-deployment.yaml" at <include "chart.license.volume" .>: error calling include: template: templates/_helpers.tpl:297:18: executing "chart.license.volume" at <.Values.license.secret.name>: can't evaluate field Values in type []interface {}

Caused by using . from unexpected context from with clause.

@zekker6
victoria-metrics-cluster: fix vminsert template for extra volumes
2453094 
 Previously, using `extraVolumes` would trigger an error because of using `.` from unexpected `with` clause.
@zekker6 zekker6 requested review from Amper and Haleygo as code owners December 8, 2023 06:47
@github-actions github-actions bot added the cluster vmcluster helm chart related issue label Dec 8, 2023
@zekker6 zekker6 mentioned this pull request Dec 8, 2023
Closed
Haleygo
Haleygo approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@Haleygo Haleygo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zekker6 zekker6 merged commit 61e5044 into master Dec 8, 2023
13 checks passed
@zekker6 zekker6 deleted the vm-cluster/fix-vminsert-extra-volumes branch December 8, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haleygo Haleygo Haleygo approved these changes

@Amper Amper Awaiting requested review from Amper

Assignees
No one assigned
Labels
cluster vmcluster helm chart related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zekker6 @Haleygo