Fix Makefile: use spaces instead of tabs in instructions before targets #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...in the directives or else the following error gets emitted for wrong CONTAINER value: [helm-charts]$ CONTAINER=faulty make sync-dashboards Makefile:19: *** recipe commences before first target. Stop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, in the following PR #790 that was already merged into master, there is a syntax error in the Makefile. I didn't use Makefiles for decades so I forgot that tabs are a must in the target definitions, but I never even knew that they must not be used before the targets, in the instructions that are evaluated during parsing of Makefile. So this patch fixes that. The faulty Makefile is OK when CONTAINER variable was either docker or podman, but when something else is used, I got the following output:
After this patch, the values docker and podman still work as expected, and any other value give correct error message:
Sorry for inconvenience.