Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmstack: dashboards and rules upgrade, added minikube setup instructions #952

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

AndrewChubatiuk
Copy link
Collaborator

@AndrewChubatiuk AndrewChubatiuk commented Apr 1, 2024

upgraded dashboards and rules, added instructions about how to set up vmstack in minikube

@AndrewChubatiuk AndrewChubatiuk changed the title vmstack: dashboartds and rules upgrade, added minikube setup instructions vmstack: dashboards and rules upgrade, added minikube setup instructions Apr 1, 2024
Haleygo
Haleygo previously approved these changes Apr 2, 2024
Copy link
Contributor

@Haleygo Haleygo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dmitryk-dk
dmitryk-dk previously approved these changes Apr 2, 2024
Copy link
Contributor

@dmitryk-dk dmitryk-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Checked on local minikube installation

@zekker6
Copy link
Contributor

zekker6 commented Apr 2, 2024

@AndrewChubatiuk Could you add a changelog entry to mention dashboards and rules update?

@AndrewChubatiuk AndrewChubatiuk dismissed stale reviews from dmitryk-dk and Haleygo via 389bedd April 2, 2024 12:07
Copy link
Contributor

@dmitryk-dk dmitryk-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@f41gh7 f41gh7 merged commit 624f078 into VictoriaMetrics:master Apr 2, 2024
6 of 7 checks passed
@f41gh7
Copy link
Collaborator

f41gh7 commented Apr 2, 2024

Thanks for contribution!

@AndrewChubatiuk AndrewChubatiuk deleted the dashboards-upgrade branch April 2, 2024 21:16
brandshaide pushed a commit to brandshaide/helm-charts that referenced this pull request Apr 16, 2024
…ons (VictoriaMetrics#952)

* upgraded rules and dashboards, added notes for setting up vmstack in minikube

* added changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants