Skip to content

Commit

Permalink
node upgrade and added secrets to env variables (#265)
Browse files Browse the repository at this point in the history
  • Loading branch information
AndrewChubatiuk authored Jan 27, 2025
1 parent 6d0449f commit 3866505
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pr-checks-frontend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: Set up node
uses: actions/setup-node@v4
with:
node-version: 18.13.0
node-version: v20.18.2

- name: Install all dependencies
run: yarn install
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ jobs:
git_user_signingkey: true
git_commit_gpgsign: true
- name: Prepare release notes if tag not exists
env:
GRAFANA_ACCESS_POLICY_TOKEN: ${{ secrets.GRAFANA_ACCESS_POLICY_TOKEN }}
run: |
export PKG_TAG="v$(yq -r '.version' package.json)"
if git show-ref --tags --verify --quiet "refs/tags/${TAG}"; then
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18-alpine3.17
FROM node:20-alpine3.21

RUN apk update && apk upgrade
RUN apk add --update python3 make g++ # for Mac M1 processors
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"lint:fix": "yarn lint --fix",
"server": "docker compose up",
"preinstall": "cd packages/lezer-metricsql && yarn install && cd ../.. && yarn upgrade lezer-metricsql",
"sign": "[ -z $GRAFANA_ACCESS_POLICY_TOKEN ] || npx --yes @grafana/sign-plugin@latest"
"sign": "[ -z $GRAFANA_ACCESS_POLICY_TOKEN ] && echo 'skip plugin signing' || npx --yes @grafana/sign-plugin@latest"
},
"author": "VictoriaMetrics",
"license": "AGPL-3.0-only",
Expand Down

0 comments on commit 3866505

Please sign in to comment.