Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for special characters in metric names #138

Merged
merged 2 commits into from
Jan 31, 2024
Merged

add support for special characters in metric names #138

merged 2 commits into from
Jan 31, 2024

Conversation

Loori-R
Copy link
Contributor

@Loori-R Loori-R commented Jan 30, 2024

This pull request introduces support for metric names containing special characters.

Supported special characters: -, +, *, /, %, ^, =

Key Changes:

  1. Fixed the logic for switching between builder and code modes for metric names with special characters.
  2. Added an escaping character when inserting metrics with special characters from the autocomplete in code mode.

#131

dmitryk-dk
dmitryk-dk previously approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@dmitryk-dk dmitryk-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One simple comment

src/components/monaco-query-field/monaco-completion-provider/index.ts Outdated Show resolved Hide resolved
dmitryk-dk
dmitryk-dk approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@dmitryk-dk dmitryk-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good changes

@dmitryk-dk dmitryk-dk merged commit d772431 into main Jan 31, 2024
9 checks passed
@dmitryk-dk dmitryk-dk deleted the issue-131/support-metrics-special-symbols branch January 31, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryk-dk dmitryk-dk dmitryk-dk approved these changes

@hagen1778 hagen1778 Awaiting requested review from hagen1778

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Loori-R @dmitryk-dk