Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile cleanup #213

Merged
merged 1 commit into from
Dec 17, 2024
Merged

makefile cleanup #213

merged 1 commit into from
Dec 17, 2024

Conversation

AndrewChubatiuk
Copy link
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Oct 18, 2024

  • build plugin for each platform and arch instead of a single one for all platforms
  • removed unneeded tar packaging
  • use yarn only instead of mix yarn and npm
  • updated release github action pipeline

Copy link
Contributor

@dmitryk-dk dmitryk-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good! Added comment. As I can see, the build for the windows is incorrect

Makefile Outdated Show resolved Hide resolved
@AndrewChubatiuk
Copy link
Contributor Author

As I can see, the build for the windows is incorrect

updated it as well, please check

Copy link
Contributor

@dmitryk-dk dmitryk-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmitryk-dk dmitryk-dk merged commit d830b2a into main Dec 17, 2024
9 checks passed
@dmitryk-dk dmitryk-dk deleted the make-cleanup branch December 17, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants