-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makefile cleanup #213
makefile cleanup #213
Conversation
AndrewChubatiuk
commented
Oct 18, 2024
•
edited
Loading
edited
- build plugin for each platform and arch instead of a single one for all platforms
- removed unneeded tar packaging
- use yarn only instead of mix yarn and npm
- updated release github action pipeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good! Added comment. As I can see, the build for the windows is incorrect
updated it as well, please check |
7c298a9
to
f2b4d59
Compare
f2b4d59
to
ce8352c
Compare
7ad9e78
to
baff6a8
Compare
4ff4928
to
596b5d7
Compare
596b5d7
to
a733226
Compare
d4c7070
to
2b01f47
Compare
2b01f47
to
65434ea
Compare
65434ea
to
774ec0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!