Merged interaction #103
Merged interaction #103
Conversation
|
This looks great. I'm going to test this out now. |
|
Looks like something is not checked in: Error: Cannot find module './stimulatorArrow' from '/Users/myers/git/visbol-js/font/sbolv/interaction-arrows' |
|
Ah, I think I see the issue. You likely moved simulatorArrow to stimulatorArrow, but then did not commit stimulatorArrow |
|
Just Added it. |
|
Looks great. Merging. |
Addresses #99 #97 #85.
The purpose of this pull request was to remove the redundancy from interaction diagrams.
With this new approach all the interaction happening on top of a circuit are merged together and are rendered in one diagram; if the nonDNA part participating in the interaction is degraded then degradation is not shown in a separate diagram either, other wise it has to be shown separately.
Also interactions are sorted so that inhibitions and stimulation are always rendered to the left of genetic productions.
below is a segment of VisBOL rendering for a SBOL file
For that SBOL, file these interactions are rendered separately. please note that since some of these proteins in that SBOL file don't participate in any other interaction with circuits, their degradation interactions has to be rendered separately, even though degradation interactions are merged into the circuit interactions.
Merge interactions algorithm is in "lib/displayList.js" and it merges interactions using a segment id which has been given to the segments using componentDefinitions uri in "lib/getDisplayList.js".