Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update format of translations #123

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update format of translations #123

wants to merge 2 commits into from

Conversation

Mandroide
Copy link

Besides moving the files from XML to PO, I fixed the order of the keys and added missing keys.

Note: I recommend to use rebase instead of merge to avoid unnecesary commits.

@Mandroide
Copy link
Author

I added #85 #94 #111 as well. So after you rebase these commits, you can go ahead and close all previous PRs.

@Vitaliy-1
Copy link
Owner

Thanks, @Mandroide!

According to your recommendation, can you rebase, squash, and force update your branch?

@Vitaliy-1
Copy link
Owner

Ahh, your branch has 2 commits on top of the master, looks ok to me. Also, did you check those translations? Let me know if not, I'll take a closer look at them.

@Mandroide
Copy link
Author

Ahh, your branch has 2 commits on top of the master, looks ok to me. Also, did you check those translations? Let me know if not, I'll take a closer look at them.

I dit it. But you could check them out just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants