pkp#10480 Fix missing argument and update schema description

Vitaliy-1 · Jan 19, 2025 · 11f9cf4 · 11f9cf4
1 parent 6a190d0
commit 11f9cf4
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 44 deletions.
diff --git a/api/v1/submissions/PKPSubmissionController.php b/api/v1/submissions/PKPSubmissionController.php
@@ -517,7 +517,7 @@ protected function getSubmissionCollector(array $queryParams): Collector
                     break;
                 case 'isUnassigned':
                     $collector->filterByisUnassigned(true);
-                    break;    
+                    break;
             }
         }
 
@@ -549,6 +549,7 @@ public function get(Request $illuminateRequest): JsonResponse
             $genres,
             $reviewAssignments,
             null,
+            null,
             !$anonymizeReviews || $anonymizeReviews->isEmpty() ? false : $anonymizeReviews
         ), Response::HTTP_OK);
     }

diff --git a/classes/submission/maps/Schema.php b/classes/submission/maps/Schema.php
@@ -548,7 +548,7 @@ protected function getPropertyReviewRounds(Collection $reviewRounds): array
      *  `isDecidingEditorAssigned` boolean whether apart from recommend only editor, there is at least one editor without recommend only flag assigned
      *  `isCurrentUserDecidingEditor` boolean whether the current user is assigned as an editor without recommend only flag (and there are recommend only editors assigned)
      *  `currentUserAssignedRoles` array the roles of the current user in the submission per stage, user may be unassigned but have global manager role
-     *  `currentUserCanRecommendOnly`
+     *  `currentUserCanRecommendOnly` whether the current user is an editor with the recommend only flag
      *  `currentUserRecommendation` object includes the recommendation decision of the current user
      *  {
      *   `decision` => recommendation decision,

diff --git a/schemas/submission.json b/schemas/submission.json
@@ -12,9 +12,19 @@
 			"apiSummary": true
 		},
 		"availableEditorialDecisions": {
+			"description": "The editorial decisions that are available for this stage.",
 			"type": "array",
-			"description": "The list of decision types per stage",
-			"readOnly": true
+			"items": {
+				"type": "object",
+				"properties": {
+					"id": {
+						"type": "integer"
+					},
+					"label": {
+						"type": "string"
+					}
+				}
+			}
 		},
 		"canCurrentUserChangeMetadata": {
 			"type": "boolean",
@@ -243,55 +253,37 @@
 							"type": "integer"
 						}
 					},
-					"status": {
-						"type": "string"
+					"editorAssigned": {
+						"type": "boolean"
 					},
-					"statusId": {
-						"type": "integer"
+					"isDecidingEditorAssigned": {
+						"type": "boolean"
+					},
+					"isCurrentUserDecidingEditor": {
+						"type": "boolean"
+					},
+					"currentUserCanRecommendOnly": {
+						"type": "boolean"
 					},
-					"files": {
+					"currentUserRecommendation": {
 						"type": "object",
 						"properties": {
-							"count": {
-								"type": "integer"
-							}
-						}
-					},
-					"queries": {
-						"type": "array",
-						"items": {
-							"id": {
-								"type": "integer"
-							},
-							"assocType": {
-								"type": "integer"
-							},
-							"assocId": {
-								"type": "integer"
-							},
-							"stageId": {
-								"type": "integer"
+							"decision": {
+								"type": "int"
 							},
-							"seq": {
-								"type": "integer"
-							},
-							"closed": {
-								"type": "boolean"
+							"label": {
+								"type": "string"
 							}
 						}
 					},
-					"availableEditorialDecisions": {
-						"description": "The editorial decisions that are available for this stage.",
+					"recommendations": {
 						"type": "array",
-						"items": {
-							"type": "object",
-							"properties": {
-								"id": {
-									"type": "integer"
-								},
-								"label": {
-									"type": "string"
-								}
+						"properties": {
+							"decision": {
+								"type": "int"
+							},
+							"label": {
+								"type": "string"
 							}
 						}
 					}