Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for azure build #611

Merged
merged 22 commits into from
Oct 22, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
8753bf2
fix for azure build
v-jameslongo Oct 18, 2024
423b915
updated actions/upload-artifact@v1/2/3 -> v4
v-jameslongo Oct 18, 2024
a9d9e02
changed the nuget package artifact names to include the os name in th…
v-jameslongo Oct 18, 2024
3930eb3
updated actions/download-artifact@v1/2/3 -> v4
v-jameslongo Oct 18, 2024
46e975f
attempt to update the image to address upload-artifacts > v1
v-jameslongo Oct 18, 2024
d692b93
attempt to update the image to address upload-artifacts > v1
v-jameslongo Oct 18, 2024
27f2e83
updated paths related to artifact@v4 changes
v-jameslongo Oct 18, 2024
7111814
troubleshoot dotnet_nugets
v-jameslongo Oct 18, 2024
04eea0d
troubleshoot dotnet_nugets
v-jameslongo Oct 18, 2024
db62eea
troubleshoot dotnet_nugets
v-jameslongo Oct 18, 2024
d0cdc63
troubleshoot dotnet_nugets
v-jameslongo Oct 18, 2024
ea589ea
troubleshoot build_rlclientlib
v-jameslongo Oct 18, 2024
08617a0
troubleshoot build_rlclientlib
v-jameslongo Oct 18, 2024
6df4ae4
troubleshoot build_rlclientlib
v-jameslongo Oct 18, 2024
a5c810d
troubleshoot lint job
v-jameslongo Oct 21, 2024
bc02100
troubleshoot lint job
v-jameslongo Oct 21, 2024
1b77a57
troubleshoot lint job
v-jameslongo Oct 21, 2024
761be0f
troubleshoot lint job
v-jameslongo Oct 21, 2024
824ea04
troubleshoot lint job
v-jameslongo Oct 21, 2024
e344539
updated python builds to vowpalwabbit/rl-manylinux-2_28-build:latest
v-jameslongo Oct 22, 2024
8650a04
troubleshoot python wheel builds
v-jameslongo Oct 22, 2024
43a5d1a
troubleshoot python wheel builds
v-jameslongo Oct 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 82 additions & 0 deletions CMakePresets.json
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,72 @@
"value": "On"
}
}
},
{
"name": "vcpkg-azure",
"inherits": "default",
"cacheVariables": {
"CMAKE_BUILD_TYPE": {
"type": "STRING",
"value": "Release"
},
"vw_USE_AZURE_FACTORIES": {
"type": "BOOL",
"value": "ON"
},
"RL_LINK_AZURE_LIBS": {
"type": "BOOL",
"value": "ON"
}
}
},
{
"name": "vcpkg-azure-static",
"inherits": "vcpkg-azure",
"cacheVariables": {
"RL_STATIC_DEPS": {
"type": "BOOL",
"value": "ON"
}
}
},
{
"name": "vcpkg-azure-static-windows",
"inherits": "vcpkg-azure-static",
"cacheVariables": {
"CMAKE_MSVC_RUNTIME_LIBRARY": {
"type": "STRING",
"value": "MultiThreaded$<$<CONFIG:Debug>:Debug>"
},
"VCPKG_TARGET_TRIPLET": {
"type": "STRING",
"value": "x64-windows-static"
},
"VCPKG_HOST_TRIPLET": {
"type": "STRING",
"value": "x64-windows-static"
}
}
},
{
"name": "vcpkg-azure-static-linux",
"inherits": "vcpkg-azure-static",
"cacheVariables": {
"VCPKG_TARGET_TRIPLET": {
"type": "STRING",
"value": "x64-linux"
}
}
},
{
"name": "vcpkg-azure-static-osx",
"inherits": "vcpkg-azure-static",
"cacheVariables": {
"VCPKG_TARGET_TRIPLET": {
"type": "STRING",
"value": "x64-osx"
}
}
}
],
"buildPresets": [
Expand All @@ -156,6 +222,22 @@
{
"name": "vcpkg-release",
"configurePreset": "vcpkg-release"
},
{
"name": "vcpkg-azure",
"configurePreset": "vcpkg-azure"
},
{
"name": "vcpkg-azure-static-windows",
"configurePreset": "vcpkg-azure-static-windows"
},
{
"name": "vcpkg-azure-static-linux",
"configurePreset": "vcpkg-azure-static-linux"
},
{
"name": "vcpkg-azure-static-osx",
"configurePreset": "vcpkg-azure-static-osx"
}
],
"testPresets": [
Expand Down
7 changes: 6 additions & 1 deletion include/azure_credentials_provider.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,14 @@ inline std::chrono::system_clock::duration get_gmt_offset()
};
std::time_t now = std::time(nullptr);
std::tm local_tm{};
localtime_s(&local_tm, &now);
std::tm gmt_tm{};
# ifdef _WIN32
localtime_s(&local_tm, &now);
gmtime_s(&gmt_tm, &now);
# else
localtime_r(&now, &local_tm);
gmtime_r(&now, &gmt_tm);
# endif
return get_time_point(local_tm) - get_time_point(gmt_tm);
}
} // namespace
Expand Down
Loading