Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing header update wrt compiler differences #613

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

v-jameslongo
Copy link
Collaborator

Summary

This pull request adds the missing includes in container_iterator.h, decision_response.h, rl_sim_cpp/person.h and rl_sim_cpp/robot_joint.h to address uint32_t type errors that arise due to differences in how compilers handle standard headers.

Details

The uint32_t type was used in multiple files without including , which caused compilation issues on certain environments where the type wasn't implicitly available.

This fix ensures explicit inclusion of the necessary header, making the code more portable and consistent across different compiler configurations.

Impact

Resolves build failures on environments that are stricter about standard header inclusion.

Improves code portability and compatibility across different build environments.

Copy link
Member

@rajan-chari rajan-chari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v-jameslongo v-jameslongo merged commit 84d5490 into master Nov 4, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants