Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 2.7 and Django < 2.0 #14

Open
wants to merge 13 commits into
base: development
Choose a base branch
from

Conversation

jorenham
Copy link

This removes the six dependency, many of the compat.py functions, and a lot of other code, that now has become irrelevant.

@W1ldPo1nter
Copy link
Owner

Thanks, this certainly has to be done at some point. However, I'm going to leave this open for now as I don't plan to drop the Python 2.7 support just yet (for the simple reason that I still have some legacy projects to tend to, which benefit from the library).

@jorenham
Copy link
Author

jorenham commented Feb 6, 2024

@W1ldPo1nter Legacy projects will still be able to use django-queryable-properties just fine. They just won't be able to use the newer versions. This is what all major projects have done, including Django, and even Python (since august 2020).

@W1ldPo1nter
Copy link
Owner

W1ldPo1nter commented Feb 7, 2024

Sure, my point was that these legacy projects would also benefit from further updates to the library (which can easily be upgraded even in such projects due to having basically no dependencies). Quite a few fixes I've made to django-queryable-properties were based on bugs that I've encountered by using the library in those projects.

As stated before, I do plan to drop support for older versions at some point, so your work won't be in vain. I just don't want to do it just yet, which is why I'm leaving this PR open to be merged at a later date.

@wolph
Copy link

wolph commented Feb 7, 2024

Both Django and Python stopped support for 2.7 roughly 4 years ago.

There have been multiple security issues in Django since that time so I do hope that your legacy projects are not Internet facing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants