Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fully active check in start() #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shaseley
Copy link

@shaseley shaseley commented Sep 25, 2023

@shaseley
Copy link
Author

@reillyeon can you PTAL? This is follow-up from https://chromium-review.googlesource.com/c/chromium/src/+/4810975.

A couple notes:

  1. IIUC this can be used on workers, so this checks that the object is a Window, but the test below does not check that -- probably a bug?
  2. The linked wpt is failing on wpt.fyi, but not in chrome with run_web_tests or run_wpt_tests. Running with wpt serve doesn't seem to include the testdriver-vendor.js file, so I'm not sure how to debug this -- do you happen to have any ideas?

@reillyeon
Copy link
Collaborator

  1. The linked wpt is failing on wpt.fyi, but not in chrome with run_web_tests or run_wpt_tests. Running with wpt serve doesn't seem to include the testdriver-vendor.js file, so I'm not sure how to debug this -- do you happen to have any ideas?

I'm not sure. I haven't tried running tests with wpt serve in a long time.

Comment on lines +284 to +285
1. If the [=relevant global object=] of [=this=] is a {{Window}} object whose
[=associated Document=] is not [=fully active=], return [=a promise rejected with=]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The equivalent worker concept is "active needed worker". You're right that the code below assumes a Document because the Permissions Policy spec does not currently define how it works in workers. In Chromium, since this API is only available in dedicated workers, the permissions policy is simply inherited from the owning document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants