-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MathML defaults #250
Merged
Merged
MathML defaults #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on top of PR #244, which the review UI apparently doesn't expect. For now, please look at only the last commit. :-/ |
mozfreddyb
approved these changes
Jan 15, 2025
annevk
reviewed
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spotted what I think are mistakes. Looks okay otherwise.
annevk
approved these changes
Jan 16, 2025
otherdaniel
force-pushed
the
mathml-lists
branch
from
January 16, 2025 14:27
0bc1294
to
d42e82c
Compare
fred-wang
reviewed
Jan 17, 2025
otherdaniel
force-pushed
the
mathml-lists
branch
from
January 17, 2025 13:18
d42e82c
to
e9fc93f
Compare
Thanks for the extra review @fred-wang, good catch 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MathML default safelist, based on dicussion in #103.
Preview | Diff