Skip to content

Commit

Permalink
Update spec based on comments and suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
[email protected] committed Dec 18, 2024
1 parent b1bb686 commit a742ac1
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions spec.bs
Original file line number Diff line number Diff line change
Expand Up @@ -8418,9 +8418,9 @@ an {{unsigned short}}-or-null |experimentGroupId|, an [=origin=] |topLevelOrigin
1. [=list/Append=] |group|'s [=interest group/trusted bidding signals keys=] into
|compressionGroupMap|[|compressionGroupId|][|partitionId|]["bidding_keys"].
1. [=map/For each=] |id| → |group| in |compressionGroupMap|:
1. Let |compressionGroup| be an empty [=bidding compression group=].
1. Set |compressionGroup|'s [=bidding compression group/compression group id=] to |id|.
1. Set |compressionGroup|'s [=bidding compression group/partition=] to an empty [=list=].
1. Let |compressionGroup| be a [=bidding compression group=], whose
[=bidding compression group/compression group id=] is |id|, and
[=bidding compression group/partition=] is an empty [=list=].
1. [=list/For each=] |partition| in |group|'s [=map/values=]:
1. [=list/Append=] |partition| to |compressionGroup|'s [=bidding compression group/partition=].
1. [=list/Append=] |compressionGroup| to |compressionGroups|.
Expand Down Expand Up @@ -8807,7 +8807,6 @@ To <dfn>batch and fetch trusted scoring signals</dfn> given a [=trusted scoring
1. Otherwise:
1. Select a non-[=list/is empty|empty=] [=set/subset=] of |batcher|'s [=trusted scoring
signals batcher/request map=][|key|], called |entriesToBatch|.
1. Set |entriesToBatch| to |batcher|'s [=trusted scoring signals batcher/request map=][|key|].
1. [=map/Remove=] |key| from |batcher|'s [=trusted scoring signals batcher/request map=].
1. Let « |requestBody|, |renderUrlIdMap|, |context| » be the result of [=building batched
trusted key value scoring signals request body=] for |entriesToBatch|.
Expand All @@ -8833,6 +8832,7 @@ To <dfn>batch and fetch trusted scoring signals</dfn> given a [=trusted scoring
1. If |scoringDataVersionMap| is not null:
1. Set |result|'s [=trusted scoring signals reply/data version=] to |scoringDataVersionMap|
[|entry|'s [=URL serializer|serialized=] [=trusted scoring signals request/render URL=]].
1. Set |entry|'s [=trusted scoring signals request/reply=] to |result|.
1. Otherwise, [=list/for each=] |entry| in |entriesToBatch|:
1. Set |entry|'s [=trusted scoring signals request/reply=] to failure.

Expand Down

0 comments on commit a742ac1

Please sign in to comment.