[spec] Add B&A k-anonymity fields #1360
Open
+77
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingxinwu
reviewed
Feb 3, 2025
Yes. |
qingxinwu
reviewed
Feb 4, 2025
spec.bs
Outdated
| @@ -3521,12 +3522,12 @@ A <dfn>server auction response</dfn> is a [=struct=] that contains auction resul | |||
| A <dfn>server auction ghost winner bid info</dfn> is a [=struct=] with the following [=struct/items=]: | |||
| <dl dfn-for="server auction ghost winner bid info"> | |||
| : <dfn>ad render url</dfn> | |||
| :: [=URL=]. The [=leading bid info/leading non-k-anon-enforced bid=]'s [=generated bid/ad descriptor=]'s [=ad descriptor/url=] from the | |||
| auction. | |||
| :: A. [=URL=]. The [=leading bid info/leading non-k-anon-enforced bid=]'s | |||
There was a problem hiding this comment.
Suggested change
| :: A. [=URL=]. The [=leading bid info/leading non-k-anon-enforced bid=]'s | |
| :: A [=URL=]. The [=leading bid info/leading non-k-anon-enforced bid=]'s |
spec.bs
Outdated
| :: A [=list=] of [=URLs=]. A list of the [=leading bid info/leading non-k-anon-enforced bid=]'s | ||
| [=generated bid/ad component descriptors=]'s [=ad descriptor/urls=] from the | ||
| server auction. | ||
| : <dfn>modified_bid</dfn> |
There was a problem hiding this comment.
Suggested change
| : <dfn>modified_bid</dfn> | |
| : <dfn>modified bid</dfn> |
spec.bs
Outdated
| :: A. [=URL=]. The [=leading bid info/leading non-k-anon-enforced bid=]'s | ||
| [=generated bid/ad descriptor=]'s [=ad descriptor/url=] from the auction. | ||
| : <dfn>ad components</dfn> | ||
| :: A [=list=] of [=URLs=]. A list of the [=leading bid info/leading non-k-anon-enforced bid=]'s |
There was a problem hiding this comment.
nit
Suggested change
| :: A [=list=] of [=URLs=]. A list of the [=leading bid info/leading non-k-anon-enforced bid=]'s | |
| :: A [=list=] of [=URLs=]. A list of the [=leading bid info/leading non-k-anon-enforced bid=]'s |
| : <dfn>modified_bid</dfn> | ||
| :: [=bid with currency=]. Contains the non-k-anonymous winning bid's [=generated bid/modified bid=] | ||
| when not null, otherwise the non-k-anonymous winning bid's [=generated bid/bid=]. | ||
| : <dfn>ad metadata</dfn> |
There was a problem hiding this comment.
this and the two id fields below all need to be initially null, since they're only set when the response has corresponding fields: https://github.com/privacysandbox/draft-ietf-bidding-and-auction-services/pull/16/files#diff-740039e394c453ba5ca4c6c7cc2d4bec9399b504e2a279c28e1625ab0e87dbe9R1120. Otherwise, their values are unset, instead of null.
spec.bs
Outdated
| : <dfn>interest group name</dfn> | ||
| :: A [=string=]. The non-k-anonymous winning bid's interest group [=interest group/name=]. | ||
| : <dfn>ghost winner bid info</dfn> | ||
| :: Null or a [=server auction ghost winner bid info=]. Contains information needed for |
There was a problem hiding this comment.
this needs to be "initially null" as well, since in the IETF spec, it's only set when the response has the field, and not set to null there. So otherwise, the field's value is unset here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the fields to the server response needed for Bidding and Auction Services k-anonymity support. A separate CL will be filed describing how these fields are interpreted by a browser.
This CL also removes some trailing whitespace that found its way into the spec.
Preview | Diff