Fixes #220: More fully specify Sec-CH-UA-Platform-Version

[erik-anderson]

Document expected version formats by platform based on the currently shipping implementation in Chromium.

On Windows, we diverge from the current shipping implementation by defining it in terms of the Windows.Foundation.UniversalApiContract per the discussion in #220.

---

Preview | Diff

[erik-anderson]

@miketaylr I haven't installed the Bikeshed tooling so there may be some formatting things that need to be cleaned up.

[miketaylr]

@miketaylr I haven't installed the Bikeshed tooling so there may be some formatting things that need to be cleaned up.

👍 Formatting looks good, per https://pr-preview.s3.amazonaws.com/erik-anderson/ua-client-hints/pull/245.html

[miketaylr]

Thanks for the PR! Looks good, just a few suggested tweaks.

@erik-anderson also, please add your name to https://wicg.github.io/ua-client-hints/#ack (if you'd like).

[erik-anderson]

@miketaylr I believe this aligns with what's currently in Chrome Canary. Previously the platform version number format was a little all over the place which https://chromium-review.googlesource.com/c/chromium/src/+/2891972 recently changed to always report three version components.

For example, on Windows it was reporting "10.0" (in Stable right now) and now reports "10.0.0" (in Canary right now).

Would you prefer me to update the Windows description to have three parts (with the 1st component being the UniversalApiContract version and the 2nd and 3rd being 0)?

[miketaylr]

I believe this aligns with what's currently in Chrome Canary. Previously the platform version number format was a little all over the place which https://chromium-review.googlesource.com/c/chromium/src/+/2891972 recently changed to always report three version components.

Oh hey, I somehow missed that landing 😅 .

Would you prefer me to update the Windows description to have three parts (with the 1st component being the UniversalApiContract version and the 2nd and 3rd being 0)?

I think there's a pretty good argument for consistency if we go that route. WDYT?

[miketaylr]

LGTM! I'll defer to you if you think we should also require 3 components for Windows (and hold off merging until you let me know). If so, we should update the "one to three version parts" for "Other platforms" to be consistent.

[erik-anderson]

@miketaylr I think consistency for parsing across platforms is reasonable. We'll still ensure reasonable version comparison checks on Windows by sticking with only filling in the significant most version component. Please merge if the latest commit looks good.

[miketaylr]

LGTM, thanks!