Error bar Code Update #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o new_branch to resolve non-fast-forward errors
maxwellmb
reviewed
Aug 16, 2023
There was a problem hiding this comment.
@Shou-Bonn what are all these changes here?
maxwellmb
reviewed
Aug 16, 2023
There was a problem hiding this comment.
Why is this whole function commented out? Is it not used, but causing problems?
|
Overall it would be better (in the future) to break some of these commits up into smaller chunks, since you're solving multiple problems at once here. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the code update to add correct error bars on variability plots based on the standard deviation of data points.
Please only merge the changes in
dataset.pyandwircpol_masks.py. Thanks.