Add verzik p2 area sounds mute #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New verzik p2 attack sounds were added with this update: https://oldschool.runescape.wiki/w/Update:A_Night_At_The_Theatre_Rework. Example of the old sounds here: https://www.youtube.com/watch?v=jNbOC7BIPXs&ab_channel=GranddadJad (ignore that it's on the p2 trainer, the sounds are correct to old verzik). New sounds here: https://youtu.be/olDqj5My_LA?t=193.
I also added a test to 1-click run the dev build, copied from another plugin. Updated the runelite version because I was getting errors on launch otherwise, but not sure if you want that split out (idk if it's necessary for the code, or just to make the local client work).
I have a separate PR open with this on annoyance mute: Broooklyn/runelite-external-plugins#78, but that's been a bit unresponsive and I think it's better grouped with other tob things anyway.