Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Correctly escape data-wovnio attribute in snippet #141

Merged
merged 3 commits into from
Apr 11, 2019

Conversation

torkelbe
Copy link
Contributor

@torkelbe torkelbe commented Apr 3, 2019

Purpose/goal of Pull Request (Issue #)

Correctly escape data-wovnio attribute in the widget snippet when using fallback method.

Comments

wovnrb's fallback method is currently inserting a snippet that is incorrectly escaped twice like this

<script src="//j.wovn.io/1" async="true" data-wovnio="key=Gl5Niu&amp;amp;backend=true&amp;amp;currentLang=en&amp;amp;defaultLang=en&amp;amp;urlPattern=path&amp;amp;langCodeAliases={}&amp;amp;version=WOVN.rb_2.0.1" data-wovnio-type="fallback_snippet">

With this change, the content of data-wovnio will only be escaped once, like this

<script src="//j.wovn.io/1" async="true" data-wovnio="key=Gl5Niu&amp;backend=true&amp;currentLang=en&amp;defaultLang=en&amp;urlPattern=path&amp;langCodeAliases={}&amp;version=WOVN.rb_2.0.1" data-wovnio-type="fallback_snippet">

'Readline' for breakpoint debugging

This PR also adds the rb-readline gem, which we now need for breakpoint debugging.

@a-bougouin a-bougouin merged commit b500aa6 into master Apr 11, 2019
@a-bougouin a-bougouin deleted the hotfix/escape_data-wovnio branch April 11, 2019 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants