Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not use useLayoutEffect on SSR #2140

Merged
merged 1 commit into from
Jul 31, 2023
Merged

fix: do not use useLayoutEffect on SSR #2140

merged 1 commit into from
Jul 31, 2023

Conversation

theo-mesnil
Copy link
Contributor

Fixes #2138

@theo-mesnil theo-mesnil requested a review from a team as a code owner July 26, 2023 14:00
@github-actions
Copy link

👀 Visit Preview

@theo-mesnil theo-mesnil merged commit eacb9a5 into master Jul 31, 2023
4 checks passed
@theo-mesnil theo-mesnil deleted the fix-use-layout-effect branch July 31, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isaacmaamouche Isaacmaamouche Isaacmaamouche approved these changes

@mleralec mleralec mleralec approved these changes

@klacointe klacointe Awaiting requested review from klacointe

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useLayoutEffect Warning in SSR context
3 participants
@theo-mesnil @mleralec @Isaacmaamouche