Wandalen · wtools-bot · Aug 30, 2024 · Nov 5, 2024 · Nov 5, 2024 · Nov 6, 2024
diff --git a/Cargo.toml b/Cargo.toml
@@ -29,9 +29,9 @@ discord_url = "https://discord.gg/m3YfbXpUUY"
 # Source :: https://github.com/obox-systems/conventions/blob/master/code_style.md#lints-and-warnings
 
 # Denies non-idiomatic code for Rust 2018 edition.
-rust_2018_idioms = "deny"
+rust_2018_idioms = { level = "deny", priority = -1 }
 # Denies using features that may break in future Rust versions.
-future_incompatible = "deny"
+future_incompatible = { level = "deny", priority = -1 }
 # Warns if public items lack documentation.
 missing_docs = "warn"
 # Warns for public types not implementing Debug.
@@ -41,9 +41,9 @@ unsafe-code = "warn"
 
 [workspace.lints.clippy]
 # Denies restrictive lints, limiting certain language features/patterns.
-restriction = "warn"
+#restriction = { level = "deny", priority = -1 }
 # Denies pedantic lints, enforcing strict coding styles and conventions.
-pedantic = "warn"
+pedantic = { level = "warn", priority = -1 }
 # Denies undocumented unsafe blocks.
 undocumented_unsafe_blocks = "deny"
 # xxx : check
@@ -492,7 +492,7 @@ version = "~0.2.0"
 path = "module/move/sqlx_query"
 
 [workspace.dependencies.deterministic_rand]
-version = "~0.5.0"
+version = "~0.6.0"
 path = "module/move/deterministic_rand"
 
 [workspace.dependencies.crates_tools]
@@ -536,4 +536,36 @@ version = "0.1.83"
 [workspace.dependencies.tokio]
 version = "1.41.0"
 features = []
-default-features = false
+default-features = false
+
+[workspace.dependencies.anyhow]
+version = "~1.0"
+# features = []
+# default-features = false
+
+[workspace.dependencies.thiserror]
+version = "~1.0"
+# features = []
+# default-features = false
+
+[workspace.dependencies.hashbrown]
+version = "~0.14.3"
+# optional = true
+default-features = false
+# features = [ "default" ]
+
+[workspace.dependencies.paste]
+version = "~1.0.14"
+default-features = false
+
+[workspace.dependencies.tempdir]
+version = "~0.3.7"
+
+[workspace.dependencies.rustversion]
+version = "~1.0"
+
+[workspace.dependencies.num-traits]
+version = "~0.2"
+
+[workspace.dependencies.rand]
+version = "0.8.5"
diff --git a/cgtools b/cgtools
diff --git a/module/alias/instance_of/src/typing/implements_lib.rs b/module/alias/instance_of/src/typing/implements_lib.rs
@@ -15,7 +15,7 @@
 // #[ macro_use ]
 mod implements_impl;
 
-/// Internal namespace.
+/// Define a private namespace for all its items.
 mod private
 {
 

diff --git a/module/alias/instance_of/src/typing/is_slice_lib.rs b/module/alias/instance_of/src/typing/is_slice_lib.rs
@@ -12,7 +12,7 @@
 
 #![ doc = include_str!( concat!( env!( "CARGO_MANIFEST_DIR" ), "/", "Readme.md" ) ) ]
 
-/// Internal namespace.
+/// Define a private namespace for all its items.
 mod private
 {
 

diff --git a/module/alias/wtest_basic/src/test/basic/helper.rs b/module/alias/wtest_basic/src/test/basic/helper.rs
@@ -3,7 +3,7 @@
 //! Helpers.
 //!
 
-/// Internal namespace.
+/// Define a private namespace for all its items.
 mod private
 {
 

diff --git a/module/alias/wtest_basic/src/test/basic/mod.rs b/module/alias/wtest_basic/src/test/basic/mod.rs
@@ -3,7 +3,7 @@
 //! Basic tools for testing.
 //!
 
-/// Internal namespace.
+/// Define a private namespace for all its items.
 mod private
 {
 }

diff --git a/module/core/async_from/src/lib.rs b/module/core/async_from/src/lib.rs
@@ -11,7 +11,7 @@ pub mod dependency
   pub use ::async_trait;
 }
 
-/// Internal namespace.
+/// Define a private namespace for all its items.
 #[ cfg( feature = "enabled" ) ]
 mod private
 {

diff --git a/module/core/async_tools/src/lib.rs b/module/core/async_tools/src/lib.rs
@@ -12,7 +12,7 @@ pub mod dependency
   pub use ::async_from;
 }
 
-/// Internal namespace.
+/// Define a private namespace for all its items.
 #[ cfg( feature = "enabled" ) ]
 mod private
 {

diff --git a/module/core/clone_dyn/src/lib.rs b/module/core/clone_dyn/src/lib.rs
@@ -14,7 +14,7 @@ pub mod dependency
   pub use ::clone_dyn_types;
 }
 
-/// Internal namespace.
+/// Define a private namespace for all its items.
 #[ cfg( feature = "enabled" ) ]
 mod private
 {

diff --git a/module/core/clone_dyn_types/Readme.md b/module/core/clone_dyn_types/Readme.md
@@ -1,5 +1,5 @@
 <!-- {{# generate.module_header{} #}} -->
-# Module :: clone_dyn_types
+# Module :: `clone_dyn_types`
 <!--{ generate.module_header.start() }-->
  [![experimental](https://raster.shields.io/static/v1?label=&message=experimental&color=orange)](https://github.com/emersion/stability-badges#experimental) [![rust-status](https://github.com/Wandalen/wTools/actions/workflows/module_clone_dyn_push.yml/badge.svg)](https://github.com/Wandalen/wTools/actions/workflows/module_clone_dyn_push.yml) [![docs.rs](https://img.shields.io/docsrs/clone_dyn_types?color=e3e8f0&logo=docs.rs)](https://docs.rs/clone_dyn_types) [![Open in Gitpod](https://raster.shields.io/static/v1?label=try&message=online&color=eee&logo=gitpod&logoColor=eee)](https://gitpod.io/#RUN_PATH=.,SAMPLE_FILE=module%2Fcore%2Fclone_dyn%2Fexamples%2Fclone_dyn_trivial.rs,RUN_POSTFIX=--example%20clone_dyn_trivial/https://github.com/Wandalen/wTools) [![discord](https://img.shields.io/discord/872391416519737405?color=eee&logo=discord&logoColor=eee&label=ask)](https://discord.gg/m3YfbXpUUY)
 <!--{ generate.module_header.end }-->

diff --git a/module/core/clone_dyn_types/src/lib.rs b/module/core/clone_dyn_types/src/lib.rs
@@ -10,7 +10,7 @@ pub mod dependency
 {
 }
 
-/// Internal namespace.
+/// Define a private namespace for all its items.
 // #[ cfg( any( not( feature = "no_std" ), feature = "use_alloc" ) ) ]
 #[ cfg( feature = "enabled" ) ]
 mod private
@@ -39,6 +39,7 @@ mod private
     T : Clone,
   {
     #[ inline ]
+    #[ allow( clippy::implicit_return, clippy::as_conversions, clippy::ptr_as_ptr ) ]
     fn __clone_dyn( &self, _ : DontCallMe ) -> *mut ()
     {
       Box::< T >::into_raw( Box::new( self.clone() ) ) as *mut ()
@@ -51,6 +52,7 @@ mod private
     T : Clone,
   {
     #[ inline ]
+    #[ allow( clippy::implicit_return, clippy::as_conversions, clippy::ptr_as_ptr ) ]
     fn __clone_dyn( &self, _ : DontCallMe ) -> *mut ()
     {
       Box::< [ T ] >::into_raw( self.iter().cloned().collect() ) as *mut ()
@@ -61,14 +63,15 @@ mod private
   impl CloneDyn for str
   {
     #[ inline ]
+    #[ allow( clippy::as_conversions, clippy::ptr_as_ptr, clippy::implicit_return ) ]
     fn __clone_dyn( &self, _ : DontCallMe ) -> *mut ()
     {
       Box::< str >::into_raw( Box::from( self ) ) as *mut ()
     }
   }
 
   ///
-  /// True clone which is applicable not only to clonable entities, but to trait objects implementing CloneDyn.
+  /// True clone which is applicable not only to clonable entities, but to trait objects implementing `CloneDyn`.
   ///
   /// # Example
   ///
@@ -100,7 +103,7 @@ mod private
     // that the `CloneDyn` trait is correctly implemented for the given type `T`, ensuring that `__clone_dyn` returns a
     // valid pointer to a cloned instance of `T`.
     //
-    #[ allow( unsafe_code ) ]
+    #[ allow( unsafe_code, clippy::as_conversions, clippy::ptr_as_ptr, clippy::implicit_return, clippy::undocumented_unsafe_blocks ) ]
     unsafe
     {
       *Box::from_raw( < T as CloneDyn >::__clone_dyn( src, DontCallMe ) as *mut T )
@@ -185,7 +188,7 @@ mod private
     // The safety of this function relies on the correct implementation of the `CloneDyn` trait for the given type `T`.
     // Specifically, `__clone_dyn` must return a valid pointer to a cloned instance of `T`.
     //
-    #[ allow( unsafe_code ) ]
+    #[ allow( unsafe_code, clippy::implicit_return, clippy::as_conversions, clippy::ptr_cast_constness, clippy::ptr_as_ptr, clippy::multiple_unsafe_ops_per_block, clippy::undocumented_unsafe_blocks, clippy::ref_as_ptr ) ]
     unsafe
     {
       let mut ptr = ref_dyn as *const T;
@@ -207,22 +210,24 @@ mod private
     impl< T : Clone > Sealed for [ T ] {}
     impl Sealed for str {}
   }
-  use sealed::*;
+  use sealed::{ DontCallMe, Sealed };
 
 }
 
 #[ cfg( feature = "enabled" ) ]
 #[ doc( inline ) ]
 #[ allow( unused_imports ) ]
+#[ allow( clippy::pub_use ) ]
 pub use own::*;
 
 /// Own namespace of the module.
 #[ cfg( feature = "enabled" ) ]
 #[ allow( unused_imports ) ]
 pub mod own
 {
-  use super::*;
+  use super::orphan;
   #[ doc( inline ) ]
+  #[ allow( clippy::useless_attribute, clippy::pub_use ) ]
   pub use orphan::*;
 }
 
@@ -231,8 +236,9 @@ pub mod own
 #[ allow( unused_imports ) ]
 pub mod orphan
 {
-  use super::*;
+  use super::exposed;
   #[ doc( inline ) ]
+  #[ allow( clippy::useless_attribute, clippy::pub_use ) ]
   pub use exposed::*;
 }
 
@@ -241,8 +247,9 @@ pub mod orphan
 #[ allow( unused_imports ) ]
 pub mod exposed
 {
-  use super::*;
+  use super::prelude;
   #[ doc( inline ) ]
+  #[ allow( clippy::useless_attribute, clippy::pub_use ) ]
   pub use prelude::*;
 }
 
@@ -251,8 +258,9 @@ pub mod exposed
 #[ allow( unused_imports ) ]
 pub mod prelude
 {
-  use super::*;
+  use super::private;
   #[ doc( inline ) ]
+  #[ allow( clippy::useless_attribute, clippy::pub_use ) ]
   pub use private::
   {
     CloneDyn,

diff --git a/module/core/collection_tools/Cargo.toml b/module/core/collection_tools/Cargo.toml
@@ -11,48 +11,41 @@ documentation = "https://docs.rs/collection_tools"
 repository = "https://github.com/Wandalen/wTools/tree/master/module/core/collection_tools"
 homepage = "https://github.com/Wandalen/wTools/tree/master/module/core/collection_tools"
 description = """
-Collection of general purpose tools to manipulate collections( containers like Vec/HashMap/HashSet ).
+General purpose tools to manipulate collections( containers like Vec/HashMap/HashSet ).
 """
 categories = [ "algorithms", "development-tools" ]
 keywords = [ "fundamental", "general-purpose" ]
 
-
 [lints]
 workspace = true
 
-
 [package.metadata.docs.rs]
 features = [ "full" ]
 all-features = false
 
 [features]
 
 no_std = [
-  # "test_tools/no_std",
 ]
 
 use_alloc = [
-  "no_std", # qqq : for Anton : why is that better? -- use_alloc means that we do not use std, but alloc and hashbrown
+  "no_std",
   "hashbrown",
-  # "test_tools/use_alloc", // why is it needed? -- not needed, removed
 ]
 
 default = [
   "enabled",
-  # "reexports",
   "collection_constructors",
   "collection_into_constructors",
 ]
 
 full = [
   "enabled",
-  # "reexports",
   "collection_constructors",
   "collection_into_constructors",
 ]
 
 enabled = []
-# reexports = []
 
 # Collection constructors, like `hmap!{ "key" => "val" }`
 collection_constructors = []
@@ -63,7 +56,7 @@ collection_into_constructors = []
 [dependencies]
 
 ## external
-hashbrown = { version = "~0.14.3", optional = true, default-features = false, features = [ "default" ] }
+hashbrown = { workspace = true, optional = true, default-features = false, features = [ "default" ] }
 
 [dev-dependencies]
 test_tools = { workspace = true }

diff --git a/module/core/collection_tools/Readme.md b/module/core/collection_tools/Readme.md
@@ -1,11 +1,11 @@
 <!-- {{# generate.module_header{} #}} -->
 
-# Module :: collection_tools
+# Module :: `collection_tools`
 <!--{ generate.module_header.start() }-->
  [![experimental](https://raster.shields.io/static/v1?label=&message=experimental&color=orange)](https://github.com/emersion/stability-badges#experimental) [![rust-status](https://github.com/Wandalen/wTools/actions/workflows/module_collection_tools_push.yml/badge.svg)](https://github.com/Wandalen/wTools/actions/workflows/module_collection_tools_push.yml) [![docs.rs](https://img.shields.io/docsrs/collection_tools?color=e3e8f0&logo=docs.rs)](https://docs.rs/collection_tools) [![Open in Gitpod](https://raster.shields.io/static/v1?label=try&message=online&color=eee&logo=gitpod&logoColor=eee)](https://gitpod.io/#RUN_PATH=.,SAMPLE_FILE=module%2Fcore%2Fcollection_tools%2Fexamples%2Fcollection_tools_trivial.rs,RUN_POSTFIX=--example%20collection_tools_trivial/https://github.com/Wandalen/wTools) [![discord](https://img.shields.io/discord/872391416519737405?color=eee&logo=discord&logoColor=eee&label=ask)](https://discord.gg/m3YfbXpUUY)
 <!--{ generate.module_header.end }-->
 
-Collection of general purpose tools to manipulate collections( containers like Vec/HashMap/HashSet... ).
+General purpose tools to manipulate collections( containers like Vec/HashMap/HashSet... ).
 
 ### Basic Use Case :: Variadic Constructors for Collections
 
@@ -71,7 +71,7 @@ assert_eq!( meta_list, meta_list );
 
 ### Basic Use Case :: `no_std` `HashSet` / `HashMap`
 
-When implementing a `no_std` environment with the `use_alloc` feature in your Rust project, you'll encounter a challenge: collections like `Vec` are imported differently depending on the availability of the `std` library. Moreover, to use data structures such as `HashSet` or `HashMap` in a `no_std` context, it's necessary to depend on third-party crates, as these are not provided by the `alloc` crate directly. This crate aims to simplify the process of designing Rust libraries or applications that require these collections in a `no_std` environment, offering a more streamlined approach to working with dynamic data structures without the standard library.
+When implementing a `no_std` ( `!use_std` ) environment with the `use_alloc` feature in your Rust project, you'll encounter a challenge: collections like `Vec` are imported differently depending on the availability of the `std` library. Moreover, to use data structures such as `HashSet` or `HashMap` in a `no_std` context, it's necessary to depend on third-party crates, as these are not provided by the `alloc` crate directly. This crate aims to simplify the process of designing Rust libraries or applications that require these collections in a `no_std` environment, offering a more streamlined approach to working with dynamic data structures without the standard library.
 
 You can do
 
@@ -98,7 +98,7 @@ Instead of
 # #[ cfg( any( feature = "use_alloc", not( feature = "no_std" ) ) ) ]
 # {
 
-#[ cfg( feature = "use_alloc" ) ]
+#[ cfg( all( feature = "no_std", feature = "use_alloc" ) ) ]
 use hashbrown::HashSet; // a `no_std` replacement for `HashSet`
 #[ cfg( not( feature = "no_std" ) ) ]
 use std::collections::HashSet;
@@ -120,7 +120,8 @@ While strict macros require you to have all members of the same type, more relax
 
 For example:
 ```rust
-# #[ cfg( all( feature = "enabled", feature = "collection_into_constructors", any( not( feature = "no_std" ), feature = "use_alloc" ) ) ) ]
+# #[ cfg( all( feature = "enabled", feature = "collection_into_constructors" ) ) ]
+# #[ cfg( any( feature = "use_alloc", not( feature = "no_std" ) ) ) ]
 # {
 use std::borrow::Cow;
 let vec : Vec< String > = collection_tools::into_vec!( "&str", "String".to_string(), Cow::from( "Cow" ) );

diff --git a/module/core/collection_tools/examples/collection_tools_trivial.rs b/module/core/collection_tools/examples/collection_tools_trivial.rs
@@ -19,18 +19,15 @@
 //! a `HashMap`, making your code cleaner and more concise. This is particularly useful in cases
 //! where you need to define a map with a known set of key-value pairs upfront.
 
-#[ cfg( not( all
-(
-//   not( feature = "use_alloc" ) ) ],
-  all( feature = "enabled", feature = "collection_constructors" ),
-  any( not( feature = "no_std" ), feature = "use_alloc" )
+#[ cfg( not( all(
+  feature = "enabled",
+  feature = "collection_constructors",
+  any( feature = "use_alloc", not( feature = "no_std" ) )
 )))]
-fn main(){}
+fn main() {}
 
-// zzz : aaa : rid of `#[ cfg( not( feature = "use_alloc" ) ) ]` -- Rid of by not relying on std
-// #[ cfg( not( feature = "use_alloc" ) ) ]
 #[ cfg( all( feature = "enabled", feature = "collection_constructors" ) ) ]
-#[ cfg( any( not( feature = "no_std" ), feature = "use_alloc" ) ) ]
+#[ cfg( any( feature = "use_alloc", not( feature = "no_std" ) ) ) ]
 fn main()
 {
   use collection_tools::*;