Fix Google Cloud Storage object metadata handling #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Cloud Storage object has fixed and user-defined metadata.
Fixed metadata:
Currently item.Metadata() would only return map of user defined metadata (often just means an empty map). Fixed metadata are fields of storage.Object and would be missing in item metadata. For an example there would be no way of knowing the object content type.
This change will provide also "fixed metadata" from the stow item metadata map and allows setting them when writing. In addition to tests in this repo I have tries these changes out in my own project.
Let me know if something about this could be improved!