Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the new rust compiler target for wasm #263

Merged
merged 2 commits into from
Jan 11, 2025
Merged

Update the new rust compiler target for wasm #263

merged 2 commits into from
Jan 11, 2025

Conversation

alabulei1
Copy link
Collaborator

Use wasm32-wasip1 instead of wasm32-wasi because the wasm32-wasi target is being renamed to wasm32-wasip1 and the wasm32-wasi target will be removed from nightly in October 2024 and removed from stable Rust in January 2025.

Copy link
Member

juntao commented Jan 10, 2025

Hello, I am a PR summary agent on flows.network. Here are my reviews of code commits in this PR.


Overall Summary

Potential Issues and Errors:

  1. URL Correction: A typo in the URL wasm32-wasip1-benchmark was corrected to wasm32-wasi-benchmark. This change reverts a previous update that used the new target name and may cause confusion or break links if there are corresponding benchmarks using the correct wasip1 target.

  2. Verification Needed: It's crucial to verify that wasm32-wasip1 is fully compatible with WasmEdge and any other dependencies, as this change involves a transition from a deprecated target.

  3. Testing Required: Thorough testing of all applications that use the updated Rust compiler target is necessary to ensure compatibility and correct functionality. This includes verifying that builds succeed without errors and that runtime behavior remains consistent.

Most Important Findings:

  • Update to wasm32-wasip1 Target: The update from wasm32-wasi to wasm32-wasip1 is significant as it involves the migration to a new, more advanced target. This change affects build scripts and documentation across multiple files.

  • Consistency in Documentation: All references in the documentation have been updated consistently to reflect the new target name, ensuring that users are not misled by outdated information.

  • Correcting URL Typo: The correction of the typo from wasm32-wasip1 back to wasm32-wasi for the benchmark project is important but should be cross-checked with any existing benchmarks or documentation using the new target.

Details

Commit a09879853a7d4355c5961a008d81a54296f60635

Key Changes Summary

  1. Important Finding: Update to wasm32-wasip1 Target

    • Updated all Rust build commands to use wasm32-wasip1 instead of the deprecated wasm32-wasi. This affects numerous build scripts across various documentation files.
  2. Updated File Paths and Commands

    • Adjusted file paths in build instructions and examples to reflect changes from target/wasm32-wasi/ to target/wasm32-wasip1/.
    • Modified URLs, cargo commands, and WasmEdge compile commands accordingly.
  3. Consistent Documentation Updates

    • Ensured consistency across all documentation files by updating references to the new target.
    • Verified that all build and run examples now use the correct Rust compiler target.

Review Notes

  • Verification Needed: Ensure that wasm32-wasip1 is fully compatible with WasmEdge and that no additional changes are required in code or configurations.
  • Testing: Recommend thorough testing of all affected applications to confirm that they build and run correctly with the new target.

Commit 92f99164fc7ac7daad8bf5171d62aa19bee4206b

Key Changes Summary:

  1. URL Correction: Fixed a typo in the URL from wasm32-wasip1-benchmark to wasm32-wasi-benchmark.
  2. Consistency Check: No other functional changes, just ensuring consistency across text references.

Most Important Findings:

  • The critical update is correcting an incorrect URL (wasip1 corrected to wasi) which links to the benchmark project, maintaining accuracy and accessibility for users.
  • Minor text cleanup with no substantive impact on content.

Signed-off-by: Michael Yuan <[email protected]>

Signed-off-by: Michael Yuan <[email protected]>
@hydai hydai merged commit 403f320 into main Jan 11, 2025
6 checks passed
@hydai hydai deleted the wasm32-wasip1 branch January 11, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants