try moving history updates to background task #5493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emptyrivers
added
the
🆕 Feature Preview
|
An experimental build of WeakAuras with the changes in this pull request is available here. |
emptyrivers
commented
Oct 23, 2024
| @@ -1807,6 +1829,14 @@ local methods = { | |||
| OptionsPrivate.ClearPicks() | |||
| WeakAuras.PickDisplay(pendingPickData.id, pendingPickData.tabToShow) | |||
| end | |||
| OptionsPrivate.Private.Threads:Add("history_update", coroutine.create(function() | |||
There was a problem hiding this comment.
this is the meat of the change, I've a suspicion that doing the work to create the archive is weirdly taxing to the game (possibly due to extreme GC churn?). So, try moving that to a background task, since that seems to have been successful for the migration snapshots.
InfusOnWoW
approved these changes
Oct 27, 2024
emptyrivers
force-pushed
the
expiriment
branch
from
7b1d6b3 to
99ce5e9
Compare
should improve performance when updating auras somewhat
emptyrivers
force-pushed
the
expiriment
branch
from
99ce5e9 to
0d174b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i've been meaning to try this for a while, i can't really tell if it improves anything or not