upgrade Unit Characteristics trigger #5572
Merged
+51
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InfusOnWoW
reviewed
Dec 8, 2024
emptyrivers
force-pushed
the
unit_char
branch
from
63e05cc to
5719c5e
Compare
…Pending properties Fixes WeakAuras#5569
emptyrivers
force-pushed
the
unit_char
branch
from
5719c5e to
0ff1c4c
Compare
It's not impossible for a user to declare that a TSU variable is of type string, but then actually populate it with something else entirely. Unfortunately, "TSU variables are trustworthy" is an invariant conditions relies on, so e.g. a condition to check if a string variable contains a substring would fail if a joker populated the state variable with a non-string value. Since Conditions are evaluated on a critical path to opening options, we need to trap any errors from this kind of shenanigans to allow the user to back out of their foolishness. Simply wrapping RunConditions in xpcall will possibly lead to half finished property applications, but that is much preferable to Options bricking up.
InfusOnWoW
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
very lightly tested, because i don't have a lot of guinea pigs around at this hour