Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sound Heartbeat Single #5600

Merged
merged 2 commits into from
Dec 29, 2024
Merged

Add Sound Heartbeat Single #5600

merged 2 commits into from
Dec 29, 2024

Conversation

Jieiku
Copy link
Contributor

@Jieiku Jieiku commented Dec 28, 2024

Description

Add a single thump heartbeat sound

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

Tested Live in the game.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • Was not necessary to comment my code
  • Was not necessary to make changes to the documentation
  • My changes generate no new warnings

Notes

The sound file used is heartbeat_slow_0.wav from this page:
https://opengameart.org/content/heartbeat-sounds

It uses a CC0 license.

I pulled the sound file into Audacity, Trimmed it to a single heartbeat, adjusted the amplification, then converted to ogg.

(I tested this new file in game as well)

@Stanzilla
Copy link
Contributor

Thanks for recreating, can you also add the license info to one of the files, I forgot which, in the https://github.com/WeakAuras/WeakAuras2/tree/main/WeakAuras/Media folder? Thank you!

@Stanzilla
Copy link
Contributor

Thank you!

@InfusOnWoW InfusOnWoW merged commit 7cc5bd4 into WeakAuras:main Dec 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants