Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smallpatches #5616

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Smallpatches #5616

merged 4 commits into from
Jan 14, 2025

Conversation

InfusOnWoW
Copy link
Contributor

No description provided.

For the talent mentioned in the linked bug report, two buffs get applied
at the same time and due to how the game works they expirationTimes are
not identical, and which one is smaller changes randomly.

Comparing spell ids is easy, fast and works.

Fixes: WeakAuras#5603
Classic has the api now and a lfg tool to set your role

Fixes: WeakAuras#5610
Copy link
Contributor

@mrbuds mrbuds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking into making the "Spec Role" load option work on classic_era, but we use the value from LibSpecialization for it on cata & retail, and it doesnt use UnitGroupRolesAssigned

WeakAuras/Prototypes.lua Show resolved Hide resolved
@InfusOnWoW InfusOnWoW merged commit 4b07fa5 into WeakAuras:main Jan 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants