add factor manager interface

Web3Auth · Jan 23, 2025 · 5d41e01 · 5d41e01
1 parent b678f3c
commit 5d41e01
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 13 deletions.
diff --git a/src/interfaces.ts b/src/interfaces.ts
@@ -23,7 +23,7 @@ import BN from "bn.js";
 
 import { FactorKeyTypeShareDescription, TssShareType, USER_PATH, WEB3AUTH_NETWORK } from "./constants";
 import { ISessionSigGenerator } from "./plugins/SessionSigGenerator/ISessionSigGenerator";
-import { IDklsSignConfig, IFrostSignConfig, IRemoteFactor } from "./plugins/Signer/ISigner";
+import { IDklsSignConfig, IFrostSignConfig, IRemoteFactor, ISigner } from "./plugins/Signer/ISigner";
 
 export type CoreKitMode = UX_MODE_TYPE | "nodejs" | "react-native";
 
@@ -358,13 +358,26 @@ export interface ISignerContext {
   }>;
   preSetupDKLSSigningConfig(): Promise<IDklsSignConfig>;
   preSetupFrostSigningConfig(): Promise<IFrostSignConfig>;
+  setCustomSigner(customSigner: ISigner, remoteFactor?: IRemoteFactor): Promise<void>;
+}
+
+export interface IFactorManagerContext {
+  stateEmitter: SafeEventEmitter;
+  config: Web3AuthOptionsWithDefaults;
+  status: COREKIT_STATUS;
+  state: Web3AuthState;
+  tKey: TKeyTSS;
+  keyType: KeyType;
+  sigType: SigType;
+  verifier: string;
+  verifierId: string;
+  getWeb3AuthNetwork(): WEB3AUTH_NETWORK_TYPE;
   createFactor(createFactorParams: CreateFactorParams): Promise<string>;
-  inputFactorKey(factorKey: string): Promise<void>;
   deleteFactor(factorPub: TkeyPoint, factorKey?: BNString): Promise<void>;
-  getKeyDetails(): Record<string, unknown> & { shareDescriptions: ShareDescriptionMap };
   getMetadataKey(): string | undefined;
-  getMetadataPublicKey(): string | undefined;
-  getWeb3AuthNetwork(): WEB3AUTH_NETWORK_TYPE;
+  getKeyDetails(): Record<string, unknown> & {
+    shareDescriptions: ShareDescriptionMap;
+  };
 }
 
 export interface IMPCContext {

diff --git a/src/mpcCoreKit.ts b/src/mpcCoreKit.ts
@@ -58,6 +58,7 @@ import {
   Web3AuthOptionsWithDefaults,
   Web3AuthState,
 } from "./interfaces";
+import { DefaultSignerPlugin } from "./plugins";
 import { DefaultSessionSigGeneratorPlugin } from "./plugins/SessionSigGenerator/DefaultSessionSigGenerator";
 import { ISessionSigGenerator } from "./plugins/SessionSigGenerator/ISessionSigGenerator";
 import { IDklsSignConfig, IFrostSignConfig, IRemoteFactor, ISigner } from "./plugins/Signer/ISigner";
@@ -140,6 +141,7 @@ export class Web3AuthMPCCoreKit implements ICoreKit, IMPCContext, ISignerContext
     if (!options.hashedFactorNonce) options.hashedFactorNonce = options.web3AuthClientId;
     if (options.disableSessionManager === undefined) options.disableSessionManager = false;
     this.sessionSigGenerator = new DefaultSessionSigGeneratorPlugin(this);
+    this.signer = new DefaultSignerPlugin(this);
     this.options = options as Web3AuthOptionsWithDefaults;
 
     this.currentStorage = new AsyncStorage(this._storageBaseKey, options.storage);

diff --git a/src/plugins/Signer/DefaultSigner.ts b/src/plugins/Signer/DefaultSigner.ts
@@ -33,14 +33,6 @@ export class DefaultSignerPlugin implements ISigner {
       data = keccak256(data);
     }
 
-    // // Custom Dkls Sign
-    // if (this.customDklsSign) {
-    //   // PreSetup
-    //   const setupSigningParams = await this.context.preSetupSigning();
-    //   const result = await this.customDklsSign(setupSigningParams, data);
-    //   return result;
-    // }
-
     const isAlreadyPrecomputed = precomputedTssClient?.client && precomputedTssClient?.serverCoeffs;
     const { client, serverCoeffs, signatures } = isAlreadyPrecomputed ? precomputedTssClient : await this.context.precomputeSecp256k1();